Skip to content

Deactivate committed resource syncer for now #663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mblos merged 1 commit into from
Mar 27, 2026
Merged

Deactivate committed resource syncer for now #663

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 0 additions & 20 deletions helm/bundles/cortex-nova/alerts/nova.alerts.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -485,26 +485,6 @@ groups:
CRD retrieval. Limes scrapes may time out, affecting capacity reporting.

# Committed Resource Syncer Alerts
- alert: CortexNovaCommittedResourceSyncerNotRunning
expr: |
increase(cortex_committed_resource_syncer_runs_total{service="cortex-nova-metrics"}[2h]) == 0
or
absent(cortex_committed_resource_syncer_runs_total{service="cortex-nova-metrics"})
for: 5m
labels:
context: committed-resource-syncer
dashboard: cortex/cortex
service: cortex
severity: warning
support_group: workload-management
annotations:
summary: "Committed Resource syncer not running"
description: >
The committed resource syncer has not run in the last 2 hours or the metric is missing.
This indicates that the syncer may have stopped, is encountering errors, or the feature
is not enabled. Check the syncer logs for errors or verify the commitments-sync-task is
in the enabledTasks configuration.

- alert: CortexNovaCommittedResourceSyncerErrorsHigh
expr: increase(cortex_committed_resource_syncer_errors_total{service="cortex-nova-metrics"}[1h]) > 3
for: 5m
Expand Down
6 changes: 1 addition & 5 deletions helm/bundles/cortex-nova/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,11 +218,7 @@ cortex-knowledge-controllers:
- datasource-controllers
- knowledge-controllers
- kpis-controller
# How often the commitments syncer reconciles Limes commitments to Reservation CRDs
# 1h = 3600000000000 nanoseconds
committedResourceSyncInterval: 3600000000000
Copy link
Copy Markdown
Member

@PhilippMatthes PhilippMatthes Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

metav1.Duration? :D

enabledTasks:
- commitments-sync-task
enabledTasks: []

# Custom configuration for the cortex postgres chart.
cortex-postgres:
Expand Down
10 changes: 10 additions & 0 deletions internal/scheduling/reservations/commitments/api_change_commitments_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,16 @@ func TestCommitmentChangeIntegration(t *testing.T) {
ExpectedReservations: []*TestReservation{},
ExpectedAPIResponse: newAPIResponse("1 commitment(s) failed", "commitment long-long-long-long-long-long-long-long-long-long-long-long-long-: unexpected commitment format"),
},
{
Name: "Planned CR is ignored in validation, no scheduling or capacity reservation",
VMs: []*TestVM{},
Flavors: []*TestFlavor{m1Small},
CommitmentRequest: newCommitmentRequest("az-a", false, 1234,
createCommitment("hw_version_hana_1_ram", "project-A", "uuid-new", "planned", 200),
),
ExpectedReservations: []*TestReservation{},
ExpectedAPIResponse: newAPIResponse(),
},
{
Name: "Invalid CR name - spaces",
VMs: []*TestVM{},
Expand Down
Loading