Don't reconcile datasource on status condition changes#655
Conversation
Co-authored-by: Matthes, Philipp <p.matthes+sap@sap.com>
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughA custom predicate was added to the OpenStack datasource controller's watch setup to suppress reconciliation triggers caused solely by changes to Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~22 minutes Poem
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Test Coverage ReportTest Coverage 📊: 68.1% |
This should avoid that the openstack datasource controller goes into an endless loop when the sync fails.