coala command: use --limit-files by fleimgruber · Pull Request #18 · coala/coala-emacs

fleimgruber · 2017-07-22T19:14:22Z

Uses --limit-files instead of --files. Also, additional line-start
and line-end regexp patterns.

sils · 2017-07-22T19:14:37Z

Comment on 0fd5944, file test/resources/language/pep8.py, line 1.

The code does not comply to PEP8.

PEP8Bear, severity NORMAL, section python.

The issue can be fixed by applying the following patch:

--- a/test/resources/language/pep8.py
+++ b/test/resources/language/pep8.py
@@ -1 +1 @@
-a = 1 + 1 # <- not PEP8 compliant
+a = 1 + 1  # <- not PEP8 compliant

fleimgruber · 2017-07-22T19:20:56Z

@sils So this is the separate PR mentioned in #17. This is really how coala should be called in this case - I even vaguely remember you telling me just that during the sprint.

The issue now is that the PEP8 test file causes coala to complain when checking the repo itself. Can you somehow force this to be accepted despite that?

sils · 2017-07-24T08:39:36Z


 [python]
 bears = PEP8Bear
+files = **.py


as per gitmate result #18 (comment) maybe put the test files into an ignore?

see 875adbc which ignores the test file from root and includes it in the test subfolder (so that cask exec ert-runner picks it up). Test works, a local coala run from the root ignores the test file, but gitmate is still complaining. What am I missing? Is there a separate gitmate config?

gitmate-bot · 2017-07-24T16:54:18Z

Comment on 0fd5944, file test/resources/language/pep8.py, line 1.

The code does not comply to PEP8.

Origin: PEP8Bear, Section: python.

The issue can be fixed by applying the following patch:

--- a/test/resources/language/pep8.py
+++ b/test/resources/language/pep8.py
@@ -1 +1 @@
-a = 1 + 1 # <- not PEP8 compliant
+a = 1 + 1  # <- not PEP8 compliant

9r0x · 2017-11-06T08:51:16Z

Anyone working on this repo now? I guess 'Default' is deprecated now.

jayvdb · 2017-11-07T07:14:45Z

ping @fleimgruber

fleimgruber · 2017-11-07T07:17:46Z

Not currently working on it. Will have a look in the next days.

fleimgruber · 2017-11-08T19:46:53Z

@Grox-Ni the last commit already contains that deprecation.

fleimgruber · 2017-11-08T20:57:16Z

FYI, I am using this on a daily basis and just tried with the most recent PyPI dev version and that works as well. AFAICS, the remaining problem is that gitmate-bot does not honour the "ignore" directive, see also #18 (comment).

9r0x · 2017-11-09T00:33:26Z

@fleimgruber you are right, I have an idea to solve gitmate's problem, please see #20, do you think I should reopen it?

fleimgruber · 2017-11-11T13:54:06Z

@Grox-Ni No. What @jayvdb said in #20 (comment) and following.

nemani · 2018-02-24T12:15:35Z

@fleimgruber Are you still on this? Or should I close this? :)

fleimgruber · 2018-02-24T13:30:34Z

@nemaniarjun this is still waiting for feedback on CI failures because of gitmate-bot, see #18 (comment).

nemani · 2018-02-24T23:15:54Z

@fleimgruber @Makman2 I am confused here, which config does gitmate bot use, the one in the PR or the one on master? Also can't we just override the CI so that we can get this merged? (I mean if gitmate uses the coafile from master then we should just merge this)

Makman2 · 2018-03-17T18:26:30Z

I believe it takes it from the PR, otherwise you can't fix issues once they are on master.

Makman2 · 2018-03-17T18:26:56Z

However I don't see a problem adding the test files to the ignore setting into the coafile if I see it correctly, should be quite straightforward 👍

Makman2 · 2018-03-17T18:28:51Z

Ah sorry haven't read it properly. Let's try to rebase and see if it works. If not, we have to investigate.

Makman2 · 2018-03-17T18:28:55Z

@gitmate-bot rebase

Makman2 · 2018-03-17T18:32:55Z

Once more, gitmate was disabled.

Makman2 · 2018-03-17T18:32:58Z

@gitmate-bot rebase

gitmate-bot · 2018-03-17T18:33:00Z

Hey! I'm GitMate.io! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost permanently ⚠️

gitmate-bot · 2018-03-17T18:33:10Z

Automated rebase with GitMate.io was successful! 🎉

Makman2 · 2018-03-17T18:35:40Z

Hm seems the commits are already up-to-date, could you regenerate the commit hash @fleimgruber and repush? --> git commit --amend --no-edit && git push -f

gitmate-bot · 2018-03-18T09:46:59Z

Comment on 0fd5944, file test/resources/language/pep8.py, line 1.

The code does not comply to PEP8.

Origin: PEP8Bear, Section: python.

The issue can be fixed by applying the following patch:

--- a/tmp/tmpan329k2u/test/resources/language/pep8.py
+++ b/tmp/tmpan329k2u/test/resources/language/pep8.py
@@ -1 +1 @@
-a = 1 + 1 # <- not PEP8 compliant
+a = 1 + 1  # <- not PEP8 compliant

fleimgruber · 2018-03-18T09:47:58Z

Done. gitmate still complains.

Makman2 · 2018-04-25T17:49:25Z

Sorry for responding that late, I've become a bit busy and haven't worked through my notification queue^^

And I know the cause: I've actually missed your very first commit in this PR, because it was at the very top of this page. You have to squash the commits, gitmate will do its analysis on each commit and uses the repository state of it. So your commit that added the new filenames in .coafile does not ignore the test file yet and flags a problem.

fleimgruber · 2018-04-25T21:08:27Z

@Makman2 well, how obvious it is in hindsight... done and gitmate does not complain anymore.

Makman2 · 2018-04-28T15:59:48Z

-  :error-patterns  ((error (or "None" line) ":" (or "None" column) ":MAJOR:" (message))
-                    (warning (or "None" line) ":" (or "None" column) ":NORMAL:" (message))
-                    (info (or "None" line) ":" (or "None" column) ":INFO:" (message)))
+  :command ("coala" "--format" "{line}:{column}:{severity_str}:{message}" "--find-config" "--limit-files" source-original)


But won't limit-files filter out given files? Wouldn't this render the plugin completely useless?

04adb14 changed --limit-files to --files. The --limit-files was put in 88315e6. Also, appeal to authority: During the hackathon, this was suggested to me by @sils.

Makman2 · 2018-04-28T16:03:32Z

+  :command ("coala" "--format" "{line}:{column}:{severity_str}:{message}" "--find-config" "--limit-files" source-original)
+  :error-patterns  ((error line-start (or "None" line) ":" (or "None" column) ":MAJOR:" (message) line-end)
+                    (warning line-start (or "None" line) ":" (or "None" column) ":NORMAL:" (message) line-end)
+                    (info line-start (or "None" line) ":" (or "None" column) ":INFO:" (message) line-end))


Don't you have to adapt the coala --format to also emit line-starts and line-ends?

See :error-patterns documentation and example in http://www.flycheck.org/en/latest/developer/developing.html#writing-the-checker. The line-start and line-end are rx pattern elements and do not map to checker command results.

Makman2 · 2018-04-28T16:04:52Z

Commit message:
- Ccoala :D
- uUse
I see two commits here:

Uses --limit-files instead of --files. Also, additional line-start and line-end regexp patterns.

One change for --limit-files and one for the additional patterns.

fleimgruber · 2018-05-13T12:43:21Z

Thanks for review. I addressed your comments, changed the commit message (typos) and reverted the regexp pattern change. With your consent I would squash.

Makman2 · 2018-05-31T12:13:12Z

Alright you can squash ;) Please rectify your final commit message so things like line-end aren't mentioned any more (due to your "revert commit" :) )

Uses `--limit-files` instead of `--files`. coafile: Ignore for gitmate CI and include for ert.

fleimgruber · 2018-07-10T06:58:28Z

@Makman2 Squashed.

sils added process/pending review size/S review carefully! labels Jul 22, 2017

sils reviewed Jul 24, 2017

View reviewed changes

gitmate-bot added the status/STALE label Aug 31, 2017

gitmate-bot removed the status/STALE label Nov 6, 2017

jayvdb changed the title ~~Coala command: use --limit-files~~ coala command: use --limit-files Nov 7, 2017

This was referenced Nov 7, 2017

Fix gitmate's complain #20

Closed

Testing python file cannot pass gitmate #24

Open

gitmate-bot added the status/STALE label Nov 19, 2017

fleimgruber force-pushed the limit_files_fix branch from 875adbc to afe77d7 Compare March 18, 2018 09:46

gitmate-bot added size/XS and removed size/S labels Mar 18, 2018

fleimgruber force-pushed the limit_files_fix branch from afe77d7 to 7f60105 Compare April 25, 2018 20:34

Makman2 reviewed Apr 28, 2018

View reviewed changes

Makman2 removed the status/STALE label Apr 28, 2018

jayvdb added process/wip and removed process/pending review labels May 8, 2018

fleimgruber force-pushed the limit_files_fix branch from 7f60105 to c3f56b7 Compare May 13, 2018 12:41

gitmate-bot added process/pending review and removed process/wip labels May 13, 2018

jayvdb added process/wip and removed process/pending review labels May 31, 2018

coala command: Use --limit-files

118576d

Uses `--limit-files` instead of `--files`. coafile: Ignore for gitmate CI and include for ert.

fleimgruber force-pushed the limit_files_fix branch from c3f56b7 to 118576d Compare June 2, 2018 12:21

gitmate-bot added process/pending review and removed process/wip labels Jun 2, 2018

Conversation

fleimgruber commented Jul 22, 2017

Uh oh!

sils commented Jul 22, 2017

Uh oh!

fleimgruber commented Jul 22, 2017

Uh oh!

sils Jul 24, 2017

Choose a reason for hiding this comment

Uh oh!

fleimgruber Jul 24, 2017

Choose a reason for hiding this comment

Uh oh!

gitmate-bot commented Jul 24, 2017

Uh oh!

9r0x commented Nov 6, 2017

Uh oh!

jayvdb commented Nov 7, 2017

Uh oh!

fleimgruber commented Nov 7, 2017

Uh oh!

fleimgruber commented Nov 8, 2017

Uh oh!

fleimgruber commented Nov 8, 2017

Uh oh!

9r0x commented Nov 9, 2017

Uh oh!

fleimgruber commented Nov 11, 2017

Uh oh!

nemani commented Feb 24, 2018

Uh oh!

fleimgruber commented Feb 24, 2018

Uh oh!

nemani commented Feb 24, 2018

Uh oh!

Makman2 commented Mar 17, 2018

Uh oh!

Makman2 commented Mar 17, 2018

Uh oh!

Makman2 commented Mar 17, 2018

Uh oh!

Makman2 commented Mar 17, 2018

Uh oh!

Makman2 commented Mar 17, 2018

Uh oh!

Makman2 commented Mar 17, 2018

Uh oh!

gitmate-bot commented Mar 17, 2018

Uh oh!

gitmate-bot commented Mar 17, 2018

Uh oh!

Makman2 commented Mar 17, 2018

Uh oh!

gitmate-bot commented Mar 18, 2018

Uh oh!

fleimgruber commented Mar 18, 2018

Uh oh!

Makman2 commented Apr 25, 2018

Uh oh!

fleimgruber commented Apr 25, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Makman2 Apr 28, 2018

Choose a reason for hiding this comment

Uh oh!

fleimgruber May 13, 2018

Choose a reason for hiding this comment

Uh oh!

Makman2 Apr 28, 2018

Choose a reason for hiding this comment

Uh oh!

fleimgruber May 13, 2018

Choose a reason for hiding this comment

Uh oh!

Makman2 commented Apr 28, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fleimgruber commented May 13, 2018

Uh oh!

Makman2 commented May 31, 2018

fleimgruber commented Apr 25, 2018 •

edited

Loading

Makman2 commented Apr 28, 2018 •

edited

Loading