Address review comments on bbknn_ts - #1
Open
rcannood wants to merge 1 commit into
Open
Conversation
* renamed the component to `era_combat_bbknn`, after the ERA system and the two algorithms it combines * `method_types: [embedding, graph]`: the custom kNN graph is evaluated as is * `preferred_normalization: counts`: the method does its own normalisation * pass `--n_pca_components`, `--n_neighbors_per_batch` and `--total_k_neighbors` through to the integration code, they were unused * store a minimal output object instead of the mutated input * updated the reference to the Nature paper and the links to the renamed `google-research/era` repo * `openproblems/base_python:1` and `[hightime, highmem, midcpu]`, in line with the other methods
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Applies @mumichae's review comments from openproblems-bio#84, so you don't have to. The generated integration code itself is untouched.
era_combat_bbknn, after the ERA system and the two algorithms it combinesmethod_types: [embedding, graph]: the custom kNN graph is evaluated as is.transformonly recomputes a graph from the embedding whenuns['neighbors']is missing, so your graph was already the one the graph metrics sawpreferred_normalization: counts: the method does its own normalisation, and this is how a component declares that the preprocessing is part of the method--n_pca_components,--n_neighbors_per_batchand--total_k_neighborsthrough to the integration code -- they were declared but never read, the hardcodedconfigdict wongoogle-research/era-- the repo has been renamed and the old docs URL now 404s, whichcheck_configflags as a hard test failureopenproblems/base_python:1and[hightime, highmem, midcpu], in line with the other methodsI verified that this doesn't change the results: running your component and this one on
resources_test/task_batch_integration/cxg_immune_cell_atlasgives the same embedding and the same kNN graph. The only difference comes from the docker tag bump (:1.0.0->:1, numpy 2.2.6 -> 2.5.2, scanpy 1.10.4 -> 1.12.3), which is 2e-06 relative drift onX_emband leaves the graph topologically identical -- same neighbours for every cell,connectivitiesbit-identical. The old tag isn't an option anyway, it failscheck_configagainst the currentcommon/submodule.viash test src/methods/era_combat_bbknn/config.vsh.yamlsucceeds.Note that the branch still needs a merge with
mainbefore it can go in --run_benchmarkhas moved on quite a bit since September.Checklist before requesting a review
I have performed a self-review of my code
Check the correct box. Does this PR contain:
Proposed changes are described in the CHANGELOG.md
CI Tests succeed and look good!