convert image to node:alpine and shell to ash#6
Open
digitaldrummerj wants to merge 1 commit intoclue:masterfrom
Open
convert image to node:alpine and shell to ash#6digitaldrummerj wants to merge 1 commit intoclue:masterfrom
digitaldrummerj wants to merge 1 commit intoclue:masterfrom
Conversation
|
@digitaldrummerj I agree with you we should get the image size as small as possible, good change. @clue could we get this merged and image published? I am waitting the downloading to complete, so just wanted to raise a PR and I found @digitaldrummerj had done this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By using node:alpine for the image instead of node:latest, it reduced the size of the image from 685 megs to 78 megs.
bash is not included with alpine. ash is the included shell in alpine