test: replace deprecated ioutil usage - #428
Open
dajiaohuang wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace the deprecated
io/ioutiltest usage withio.ReadAllso the repository's stable-Go lint job no longer reports SA1019.Root cause
The v0.7.5 tag workflow resolves
go-version: stableto Go 1.26.5. Staticcheck flags the remainingio/ioutilimport innocopy_readwriter_test.go, causing the otherwise successful release workflow to stay red.Changes
io/ioutilimportio.ReadAllAPI already available in the module's Go 1.20 baselineThis is test-only and does not change runtime behavior or public APIs.
Verification
go test -timeout=2m -count=1 -race ./...(Linux amd64, Go 1.20.14)go test -timeout=2m -count=1 -race ./...(Linux amd64, Go 1.25.14)golangci-lint run(v1.64.8)go vet ./...(Windows amd64, Go 1.26.3)go mod verify(Windows amd64, Go 1.26.3)Fixes #427