Do not merge - Prototype intellisense by emitting function signatures for all classes#2016
Open
Do not merge - Prototype intellisense by emitting function signatures for all classes#2016
Conversation
michael-k
reviewed
Mar 7, 2022
Contributor
michael-k
left a comment
There was a problem hiding this comment.
Generates eg.
class Group(AWSObject):
def __init__(
self,
title: Optional[str],
template: Optional[Template] = None,
validation: bool = True,
*,
GroupName: iam_group_name = None,
ManagedPolicyArns: "list[str]" = None,
Path: iam_path = None,
Policies: "list[Policy]" = None,
):
...but iam_group_name and iam_path aren't valid types. It also shouldn't add = None for required properties.
Personally I'd prefer switching to dataclasses or pydantic instead of generating __init__ methods.
| if value.item_type: | ||
| return "[%s]" % value.item_type | ||
| if stub: | ||
| return "'list[%s]'" % value.item_type |
Contributor
There was a problem hiding this comment.
list[…] instead of typing.List[…] is only available in Python 3.9+
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on the auto-gen work and @ITProKyle typing changes, I put together a quick prototype to allow for some intellisense functionality. This is a WIP.
To try out:
Issues:
Might be of interest to @JohnPreston @michael-k