Skip to content

feat: Add dialog component - #4904

Draft
amanabiy wants to merge 3 commits into
mainfrom
dev-v3-amanabiy-dialog
Draft

feat: Add dialog component#4904
amanabiy wants to merge 3 commits into
mainfrom
dev-v3-amanabiy-dialog

Conversation

@amanabiy

Copy link
Copy Markdown
Member

Description

Related links, issue #, if available: n/a

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov

codecov Bot commented Aug 13, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 85.00000% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 97.63%. Comparing base (f2f90d4) to head (4fb0a5e).
⚠️ Report is 14 commits behind head on main.

Files with missing lines Patch % Lines
src/test-utils/dom/dialog/index.ts 46.66% 8 Missing ⚠️
src/dialog/internal.tsx 97.29% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4904      +/-   ##
==========================================
- Coverage   97.64%   97.63%   -0.01%     
==========================================
  Files         958      961       +3     
  Lines       31240    31377     +137     
  Branches    11529    11582      +53     
==========================================
+ Hits        30503    30636     +133     
+ Misses        730      695      -35     
- Partials        7       46      +39     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant