fix: visible focus ring for inverted links in One Theme (WCAG 2.4.11) - #4903
Open
Harsh-Anand-Singh wants to merge 1 commit into
Open
fix: visible focus ring for inverted links in One Theme (WCAG 2.4.11)#4903Harsh-Anand-Singh wants to merge 1 commit into
Harsh-Anand-Singh wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4903 +/- ##
=======================================
Coverage 97.66% 97.66%
=======================================
Files 958 958
Lines 31317 31317
Branches 11566 11565 -1
=======================================
Hits 30585 30585
- Misses 686 725 +39
+ Partials 46 7 -39 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
In One Theme, color="inverted" links used outside a visual context fall back to the colorBorderItemFocused ring, which resolves to the same Indigo600 primitive as the dark notification-style surfaces inverted links are designed for, making the keyboard focus ring invisible (1.00:1 on the link permutations page). Scope the inverted variant's ring fallback to currentColor under One Theme: the ring always matches the (already legible) inverted text color, guaranteeing >= 3:1 wherever the text itself passes, including light-mode flashbar/alert where a static light ring would fail. Context-driven rings inside Flashbar and Alert are unaffected, and explicit Style API focusRing.borderColor overrides still take precedence.
Harsh-Anand-Singh
marked this pull request as ready for review
August 13, 2026 14:04
Harsh-Anand-Singh
force-pushed
the
dev-v3-hanandji-linkfocusfix
branch
from
August 13, 2026 14:04
e7fcee1 to
b5b7163
Compare
Harsh-Anand-Singh
enabled auto-merge
August 13, 2026 14:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In One Theme, color="inverted" links used outside a visual context fall back to the colorBorderItemFocused ring, which resolves to the same Indigo600 primitive as the dark notification-style surfaces inverted links are designed for, making the keyboard focus ring invisible (1.00:1 on the link permutations page). Scope the inverted variant's ring fallback to currentColor under One Theme: the ring always matches the (already legible) inverted text color, guaranteeing >= 3:1 wherever the text itself passes, including light-mode flashbar/alert where a static light ring would fail.
Related links, issue #, if available: n/a
How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.