Skip to content

chore: update secondary link style for one theme #4900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mxschll merged 3 commits into from
Aug 13, 2026
Merged

chore: update secondary link style for one theme #4900

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
555de44
chore: update secondary link style for one theme
mxschll Aug 13, 2026
9679cd7
chore: update snapshots
mxschll Aug 13, 2026
e603865
chore: update snapshots
mxschll Aug 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions src/__integ__/__snapshots__/themes.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -688,6 +688,7 @@ exports[`CSS Custom Properties match previous snapshot for mode "compact" 1`] =
"color-text-link-info-hover": "#0a4a74",
"color-text-link-inverted-default": "#fafafa",
"color-text-link-inverted-hover": "#fafafa",
"color-text-link-secondary-decoration-default": "transparent",
"color-text-link-secondary-default": "#0073bb",
"color-text-link-secondary-hover": "#0a4a74",
"color-text-notification-default": "#fafafa",
Expand Down Expand Up @@ -746,6 +747,7 @@ exports[`CSS Custom Properties match previous snapshot for mode "compact" 1`] =
"color-white": "#ffffff",
"font-button-letter-spacing": "0.25px",
"font-chart-detail-size": "14px",
"font-decoration-line-link-secondary": "none",
"font-decoration-style-link": "solid",
"font-decoration-thickness-link": "1px",
"font-decoration-thickness-link-display-l": "2px",
Expand Down Expand Up @@ -1696,6 +1698,7 @@ exports[`CSS Custom Properties match previous snapshot for mode "dark" 1`] = `
"color-text-link-info-hover": "#99cbe4",
"color-text-link-inverted-default": "#fafafa",
"color-text-link-inverted-hover": "#fafafa",
"color-text-link-secondary-decoration-default": "transparent",
"color-text-link-secondary-default": "#44b9d6",
"color-text-link-secondary-hover": "#99cbe4",
"color-text-notification-default": "#fafafa",
Expand Down Expand Up @@ -1754,6 +1757,7 @@ exports[`CSS Custom Properties match previous snapshot for mode "dark" 1`] = `
"color-white": "#ffffff",
"font-button-letter-spacing": "0.25px",
"font-chart-detail-size": "14px",
"font-decoration-line-link-secondary": "none",
"font-decoration-style-link": "solid",
"font-decoration-thickness-link": "1px",
"font-decoration-thickness-link-display-l": "2px",
Expand Down Expand Up @@ -2704,6 +2708,7 @@ exports[`CSS Custom Properties match previous snapshot for mode "light" 1`] = `
"color-text-link-info-hover": "#0a4a74",
"color-text-link-inverted-default": "#fafafa",
"color-text-link-inverted-hover": "#fafafa",
"color-text-link-secondary-decoration-default": "transparent",
"color-text-link-secondary-default": "#0073bb",
"color-text-link-secondary-hover": "#0a4a74",
"color-text-notification-default": "#fafafa",
Expand Down Expand Up @@ -2762,6 +2767,7 @@ exports[`CSS Custom Properties match previous snapshot for mode "light" 1`] = `
"color-white": "#ffffff",
"font-button-letter-spacing": "0.25px",
"font-chart-detail-size": "14px",
"font-decoration-line-link-secondary": "none",
"font-decoration-style-link": "solid",
"font-decoration-thickness-link": "1px",
"font-decoration-thickness-link-display-l": "2px",
Expand Down Expand Up @@ -3712,6 +3718,7 @@ exports[`CSS Custom Properties match previous snapshot for mode "reduced-motion"
"color-text-link-info-hover": "#0a4a74",
"color-text-link-inverted-default": "#fafafa",
"color-text-link-inverted-hover": "#fafafa",
"color-text-link-secondary-decoration-default": "transparent",
"color-text-link-secondary-default": "#0073bb",
"color-text-link-secondary-hover": "#0a4a74",
"color-text-notification-default": "#fafafa",
Expand Down Expand Up @@ -3770,6 +3777,7 @@ exports[`CSS Custom Properties match previous snapshot for mode "reduced-motion"
"color-white": "#ffffff",
"font-button-letter-spacing": "0.25px",
"font-chart-detail-size": "14px",
"font-decoration-line-link-secondary": "none",
"font-decoration-style-link": "solid",
"font-decoration-thickness-link": "1px",
"font-decoration-thickness-link-display-l": "2px",
Expand Down Expand Up @@ -4720,6 +4728,7 @@ exports[`CSS Custom Properties match previous snapshot for mode "visual-refresh"
"color-text-link-info-hover": "#002b66",
"color-text-link-inverted-default": "#f9f9fa",
"color-text-link-inverted-hover": "#ffffff",
"color-text-link-secondary-decoration-default": "transparent",
"color-text-link-secondary-default": "#006ce0",
"color-text-link-secondary-hover": "#002b66",
"color-text-notification-default": "#f9f9fa",
Expand Down Expand Up @@ -4778,6 +4787,7 @@ exports[`CSS Custom Properties match previous snapshot for mode "visual-refresh"
"color-white": "#ffffff",
"font-button-letter-spacing": "0.005em",
"font-chart-detail-size": "12px",
"font-decoration-line-link-secondary": "none",
"font-decoration-style-link": "solid",
"font-decoration-thickness-link": "1px",
"font-decoration-thickness-link-display-l": "2px",
Expand Down Expand Up @@ -5728,6 +5738,7 @@ exports[`CSS Custom Properties match previous snapshot for mode "visual-refresh-
"color-text-link-info-hover": "#002b66",
"color-text-link-inverted-default": "#f9f9fa",
"color-text-link-inverted-hover": "#ffffff",
"color-text-link-secondary-decoration-default": "transparent",
"color-text-link-secondary-default": "#006ce0",
"color-text-link-secondary-hover": "#002b66",
"color-text-notification-default": "#f9f9fa",
Expand Down Expand Up @@ -5786,6 +5797,7 @@ exports[`CSS Custom Properties match previous snapshot for mode "visual-refresh-
"color-white": "#ffffff",
"font-button-letter-spacing": "0.005em",
"font-chart-detail-size": "12px",
"font-decoration-line-link-secondary": "none",
"font-decoration-style-link": "solid",
"font-decoration-thickness-link": "1px",
"font-decoration-thickness-link-display-l": "2px",
Expand Down Expand Up @@ -6736,6 +6748,7 @@ exports[`CSS Custom Properties match previous snapshot for mode "visual-refresh-
"color-text-link-info-hover": "#75cfff",
"color-text-link-inverted-default": "#f9f9fa",
"color-text-link-inverted-hover": "#ffffff",
"color-text-link-secondary-decoration-default": "transparent",
"color-text-link-secondary-default": "#42b4ff",
"color-text-link-secondary-hover": "#75cfff",
"color-text-notification-default": "#f9f9fa",
Expand Down Expand Up @@ -6794,6 +6807,7 @@ exports[`CSS Custom Properties match previous snapshot for mode "visual-refresh-
"color-white": "#ffffff",
"font-button-letter-spacing": "0.005em",
"font-chart-detail-size": "12px",
"font-decoration-line-link-secondary": "none",
"font-decoration-style-link": "solid",
"font-decoration-thickness-link": "1px",
"font-decoration-thickness-link-display-l": "2px",
Expand Down Expand Up @@ -7744,6 +7758,7 @@ exports[`CSS Custom Properties match previous snapshot for mode "visual-refresh-
"color-text-link-info-hover": "#75cfff",
"color-text-link-inverted-default": "#f9f9fa",
"color-text-link-inverted-hover": "#ffffff",
"color-text-link-secondary-decoration-default": "transparent",
"color-text-link-secondary-default": "#42b4ff",
"color-text-link-secondary-hover": "#75cfff",
"color-text-notification-default": "#f9f9fa",
Expand Down Expand Up @@ -7802,6 +7817,7 @@ exports[`CSS Custom Properties match previous snapshot for mode "visual-refresh-
"color-white": "#ffffff",
"font-button-letter-spacing": "0.005em",
"font-chart-detail-size": "12px",
"font-decoration-line-link-secondary": "none",
"font-decoration-style-link": "solid",
"font-decoration-thickness-link": "1px",
"font-decoration-thickness-link-display-l": "2px",
Expand Down
4 changes: 2 additions & 2 deletions src/link/constants.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,8 @@ $link-variants: (
'text-color-hover': awsui.$color-text-link-secondary-hover,
'text-color-active': awsui.$color-text-link-secondary-hover,
'font-weight': awsui.$font-weight-link-secondary,
'decoration-line': none,
'decoration-color': transparent,
'decoration-line': awsui.$font-decoration-line-link-secondary,
'decoration-color': awsui.$color-text-link-secondary-decoration-default,
'decoration-color-hover': awsui.$color-text-link-decoration-hover,
'letter-spacing': normal,
),
Expand Down
1 change: 1 addition & 0 deletions style-dictionary/one-theme/colors.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,7 @@ const tokens: StyleDictionary.ColorsDictionary = {
colorTextLinkHover: { light: '{colorPrimary600}', dark: '{colorPrimary400}' },
colorTextLinkSecondaryDefault: { light: '{colorNeutral850}', dark: '{colorNeutral350}' },
colorTextLinkSecondaryHover: { light: '{colorPrimary600}', dark: '{colorPrimary400}' },
colorTextLinkSecondaryDecorationDefault: '{colorTextLinkDecorationDefault}',
colorTextLinkInfoDefault: { light: '{colorPrimary600}', dark: '{colorPrimary400}' },
colorTextLinkInfoHover: { light: '{colorPrimary800}', dark: '{colorPrimary300}' },
colorTextAccent: { light: '{colorPrimary600}', dark: '{colorPrimary400}' },
Expand Down
3 changes: 2 additions & 1 deletion style-dictionary/one-theme/typography.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,8 @@ const tokens: StyleDictionary.TypographyDictionary = {
fontWeightTabs: '600',
fontSizeTabs: '14px',
fontWayfindingLinkActiveWeight: '600',
fontWeightLinkSecondary: '500',
fontWeightLinkSecondary: 'inherit',
fontDecorationLineLinkSecondary: 'underline',

// ── Alerts / flashbars ────────────────────────────────────────────────────
fontWeightAlertHeader: '500',
Expand Down
2 changes: 2 additions & 0 deletions style-dictionary/utils/token-names.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -868,6 +868,7 @@ export type ColorsTokenName =
| 'colorTextLinkDecorationHover'
| 'colorTextLinkSecondaryDefault'
| 'colorTextLinkSecondaryHover'
| 'colorTextLinkSecondaryDecorationDefault'
| 'colorTextLinkInfoDefault'
| 'colorTextLinkInfoHover'
| 'colorTextLinkInvertedDefault'
Expand Down Expand Up @@ -957,6 +958,7 @@ export type TypographyTokenName =
| 'fontDecorationThicknessLink'
| 'fontDecorationThicknessLinkDisplayL'
| 'fontDecorationStyleLink'
| 'fontDecorationLineLinkSecondary'
| 'fontPanelHeaderLineHeight'
| 'fontPanelHeaderSize'
| 'fontSideNavigationSectionHeaderSize'
Expand Down
1 change: 1 addition & 0 deletions style-dictionary/visual-refresh/colors.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,6 +320,7 @@ const tokens: StyleDictionary.ColorsDictionary = {
colorTextLinkDecorationHover: 'currentColor',
colorTextLinkSecondaryDefault: '{colorTextLinkDefault}',
colorTextLinkSecondaryHover: '{colorTextLinkHover}',
colorTextLinkSecondaryDecorationDefault: 'transparent',
colorTextLinkInfoDefault: '{colorTextLinkDefault}',
colorTextLinkInfoHover: '{colorTextLinkHover}',
colorTextLinkInvertedDefault: '{colorTextNotificationDefault}',
Expand Down
5 changes: 5 additions & 0 deletions style-dictionary/visual-refresh/metadata/colors.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1238,6 +1238,11 @@ const metadata: StyleDictionary.MetadataIndex = {
public: true,
themeable: true,
},
colorTextLinkSecondaryDecorationDefault: {
description: 'The default color of the text decoration (underline) of secondary links.',
public: false,
themeable: false,
},
colorTextLinkInfoDefault: {
description: 'The default color for info links.',
public: true,
Expand Down
5 changes: 5 additions & 0 deletions style-dictionary/visual-refresh/metadata/typography.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,6 +267,11 @@ const metadata: StyleDictionary.MetadataIndex = {
themeable: true,
public: false,
},
fontDecorationLineLinkSecondary: {
description: 'The text decoration line of secondary links. For example: underline, none.',
themeable: false,
public: false,
},
fontWeightBreadcrumbCurrent: {
description: 'The font weight of the current breadcrumb item (the page the user is currently viewing).',
themeable: true,
Expand Down
1 change: 1 addition & 0 deletions style-dictionary/visual-refresh/typography.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ export const tokens: StyleDictionary.TypographyDictionary = {
fontButtonLetterSpacing: '0.005em',
fontChartDetailSize: '{fontSizeBodyS}',
fontDecorationStyleLink: 'solid',
fontDecorationLineLinkSecondary: 'none',
fontDecorationThicknessLink: '1px',
fontDecorationThicknessLinkDisplayL: '2px',
fontDisplayLabelWeight: '700',
Expand Down
Loading