Skip to content

chore: Split base theme into a separate file that can be more easily removed/replaced at build-time - #4855

Merged
avinashbot merged 1 commit into
mainfrom
split-base-theme
Aug 13, 2026
Merged

chore: Split base theme into a separate file that can be more easily removed/replaced at build-time#4855
avinashbot merged 1 commit into
mainfrom
split-base-theme

Conversation

@avinashbot

@avinashbot avinashbot commented Aug 3, 2026

Copy link
Copy Markdown
Member

Description

See Chorus/rzZV6TJY6Zav. What if, instead of creating a themed "copy" of the components libraries, you just create a stylesheet that contains all the design tokens that the components need with the values set to the themed values? And then, you can either override it (using cascade layers or putting it later in the DOM order) or just replace this file (using bunder overrides).

This is to support the replacement strategy. Nothing in theming core changes intentionally, so it's easy to revert, this is just to verify that moving the base styles doesn't break anything (technically, don't see why it should, but it's best to play it safe).

Related links, issue #, if available: n/a

How has this been tested?

Doing a dry-run (7976441604).

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov

codecov Bot commented Aug 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.66%. Comparing base (3bbec78) to head (043e4dc).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4855   +/-   ##
=======================================
  Coverage   97.66%   97.66%           
=======================================
  Files         958      958           
  Lines       31314    31314           
  Branches    11564    11565    +1     
=======================================
  Hits        30582    30582           
+ Misses        725      686   -39     
- Partials        7       46   +39     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@avinashbot
avinashbot added this pull request to the merge queue Aug 13, 2026
Merged via the queue into main with commit c4816f9 Aug 13, 2026
60 checks passed
@avinashbot
avinashbot deleted the split-base-theme branch August 13, 2026 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants