chore: Split base theme into a separate file that can be more easily removed/replaced at build-time - #4855
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4855 +/- ##
=======================================
Coverage 97.66% 97.66%
=======================================
Files 958 958
Lines 31314 31314
Branches 11564 11565 +1
=======================================
Hits 30582 30582
+ Misses 725 686 -39
- Partials 7 46 +39 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…removed/replaced at build-time
avinashbot
force-pushed
the
split-base-theme
branch
from
August 13, 2026 12:43
e3dd8e8 to
043e4dc
Compare
avinashbot
marked this pull request as ready for review
August 13, 2026 12:47
pan-kot
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
See Chorus/rzZV6TJY6Zav. What if, instead of creating a themed "copy" of the components libraries, you just create a stylesheet that contains all the design tokens that the components need with the values set to the themed values? And then, you can either override it (using cascade layers or putting it later in the DOM order) or just replace this file (using bunder overrides).
This is to support the replacement strategy. Nothing in theming core changes intentionally, so it's easy to revert, this is just to verify that moving the base styles doesn't break anything (technically, don't see why it should, but it's best to play it safe).
Related links, issue #, if available: n/a
How has this been tested?
Doing a dry-run (7976441604).
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.