feat: Enable one-theme a11y tests#4636
Draft
at-susie wants to merge 2 commits into
Draft
Conversation
at-susie
requested review from
YueyingLu,
georgylobko,
jkuelz and
mxschll
and removed request for
YueyingLu,
georgylobko,
jkuelz and
mxschll
mxschll
reviewed
Jun 16, 2026
| function urlFormatter(inputUrl: string, mode: Mode) { | ||
| return `#/${mode}/${inputUrl}`; | ||
| function urlFormatter(inputUrl: string, mode: Mode, theme: Theme) { | ||
| const params = theme === 'one-theme' ? '?oneTheme=true' : ''; |
Member
There was a problem hiding this comment.
Should we have a param like this instead: theme=one-theme or theme=visual-refresh?
mxschll
reviewed
Jun 16, 2026
| import A11yPageObject from './a11y-page-object'; | ||
|
|
||
| type Theme = 'visual-refresh'; | ||
| type Theme = 'visual-refresh' | 'one-theme'; |
Member
There was a problem hiding this comment.
I am not sure if this will work right now, as one theme is gated behind INCLUDE_ONE_THEME=true... I'll have a look too.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4636 +/- ##
=======================================
Coverage 97.51% 97.52%
=======================================
Files 948 948
Lines 30357 30363 +6
Branches 11077 11077
=======================================
+ Hits 29604 29610 +6
Misses 706 706
Partials 47 47 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR enable one-theme a11y tests.
Related links, issue #, if available: n/a
How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.