Skip to content

revert: Removes link underline color tokens from #4621#4635

Merged
pan-kot merged 1 commit into
mainfrom
fix-link-underline-style
Jun 16, 2026
Merged

revert: Removes link underline color tokens from #4621#4635
pan-kot merged 1 commit into
mainfrom
fix-link-underline-style

Conversation

@pan-kot

@pan-kot pan-kot commented Jun 16, 2026

Copy link
Copy Markdown
Member

Description

A partial revert of #4621.

Reason: the currentValue is not accepted by theming, but an explicit value changes link styles when links are styled or focused. Need to re-evaluate the decision for themeable link underline tokens.

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@pan-kot pan-kot requested a review from a team as a code owner June 16, 2026 09:50
@pan-kot pan-kot requested review from ernst-dev and jperals and removed request for a team June 16, 2026 09:50
@pan-kot pan-kot enabled auto-merge June 16, 2026 09:51
@codecov

codecov Bot commented Jun 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.51%. Comparing base (560af5d) to head (e43d581).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4635   +/-   ##
=======================================
  Coverage   97.51%   97.51%           
=======================================
  Files         948      948           
  Lines       30346    30346           
  Branches    11067    11067           
=======================================
  Hits        29593    29593           
  Misses        706      706           
  Partials       47       47           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pan-kot pan-kot added this pull request to the merge queue Jun 16, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jun 16, 2026
@pan-kot pan-kot added this pull request to the merge queue Jun 16, 2026
Merged via the queue into main with commit 7be64a9 Jun 16, 2026
52 checks passed
@pan-kot pan-kot deleted the fix-link-underline-style branch June 16, 2026 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants