feat: Custom trigger icon for button dropdown and button group menu d…#4628
Merged
Conversation
michaeldowseza
commented
Jun 15, 2026
92ea495 to
817f1fc
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4628 +/- ##
=======================================
Coverage 97.51% 97.51%
=======================================
Files 948 948
Lines 30346 30353 +7
Branches 11067 11072 +5
=======================================
+ Hits 29593 29600 +7
- Misses 706 746 +40
+ Partials 47 7 -40 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
georgylobko
reviewed
Jun 16, 2026
…ropdown Adds iconName, iconAlt, iconUrl, and iconSvg support to the ButtonDropdown trigger (icon and inline-icon variants) and to the ButtonGroup menu-dropdown item, falling back to the default ellipsis icon when no icon is provided.
1d5f3d0 to
db347a2
Compare
georgylobko
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds iconName, iconAlt, iconUrl, and iconSvg support to the ButtonDropdown trigger (icon and inline-icon variants) and to the ButtonGroup menu-dropdown item, falling back to the default ellipsis icon when no icon is provided.
Related links, issue #, if available: n/a
How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.