Skip to content

feat: Custom trigger icon for button dropdown and button group menu d…#4628

Merged
michaeldowseza merged 2 commits into
mainfrom
feat-bd-icon-name
Jun 16, 2026
Merged

feat: Custom trigger icon for button dropdown and button group menu d…#4628
michaeldowseza merged 2 commits into
mainfrom
feat-bd-icon-name

Conversation

@michaeldowseza

@michaeldowseza michaeldowseza commented Jun 15, 2026

Copy link
Copy Markdown
Member

Description

Adds iconName, iconAlt, iconUrl, and iconSvg support to the ButtonDropdown trigger (icon and inline-icon variants) and to the ButtonGroup menu-dropdown item, falling back to the default ellipsis icon when no icon is provided.

Related links, issue #, if available: n/a

How has this been tested?

  • Updated unit tests
  • Updated permutations for items
Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Comment thread src/button-group/interfaces.ts
@codecov

codecov Bot commented Jun 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.51%. Comparing base (f968598) to head (db347a2).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4628   +/-   ##
=======================================
  Coverage   97.51%   97.51%           
=======================================
  Files         948      948           
  Lines       30346    30353    +7     
  Branches    11067    11072    +5     
=======================================
+ Hits        29593    29600    +7     
- Misses        706      746   +40     
+ Partials       47        7   -40     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@michaeldowseza michaeldowseza marked this pull request as ready for review June 15, 2026 09:20
@michaeldowseza michaeldowseza requested a review from a team as a code owner June 15, 2026 09:20
@michaeldowseza michaeldowseza requested review from georgylobko and removed request for a team June 15, 2026 09:20
Comment thread src/button-dropdown/index.tsx
Comment thread src/button-group/interfaces.ts
…ropdown

Adds iconName, iconAlt, iconUrl, and iconSvg support to the ButtonDropdown
trigger (icon and inline-icon variants) and to the ButtonGroup menu-dropdown
item, falling back to the default ellipsis icon when no icon is provided.
@michaeldowseza michaeldowseza enabled auto-merge June 16, 2026 09:23
@michaeldowseza michaeldowseza added this pull request to the merge queue Jun 16, 2026
Merged via the queue into main with commit 733f549 Jun 16, 2026
51 checks passed
@michaeldowseza michaeldowseza deleted the feat-bd-icon-name branch June 16, 2026 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants