Skip to content

fix: Support pressedIconSvg in button group#4595

Open
just-boris wants to merge 8 commits into
mainfrom
just-boris-patch-1
Open

fix: Support pressedIconSvg in button group#4595
just-boris wants to merge 8 commits into
mainfrom
just-boris-patch-1

Conversation

@just-boris

Copy link
Copy Markdown
Member

Description

Self explanatory

Related links, issue #, if available: n/a

How has this been tested?

n/a

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@just-boris just-boris requested a review from a team as a code owner June 9, 2026 16:21
@just-boris just-boris requested review from SpyZzey and removed request for a team June 9, 2026 16:21
...('pressedIconSvg' in runtimeHeaderAction &&
runtimeHeaderAction.pressedIconSvg && {
iconSvg: convertRuntimeTriggerToReactNode(runtimeHeaderAction.pressedIconSvg),
pressedIconSvg: convertRuntimeTriggerToReactNode(runtimeHeaderAction.pressedIconSvg),

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is funny

There is an existing test on pressed icon state, but because of a bug here, it incorrectly propagated pressedIconSvg as a normal iconSvg, making the test false positive

All fixed now

@codecov

codecov Bot commented Jun 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.50%. Comparing base (22d5a6b) to head (64fb7ef).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4595   +/-   ##
=======================================
  Coverage   97.50%   97.50%           
=======================================
  Files         948      948           
  Lines       30262    30262           
  Branches    11027    11026    -1     
=======================================
  Hits        29507    29507           
- Misses        708      748   +40     
+ Partials       47        7   -40     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant