feat: SideNav collapse state#4593
Draft
jkuelz wants to merge 3 commits into
Draft
Conversation
…conPosition, and design tokens - collapsed?: boolean prop for icon-only rail mode - icon?: ReactNode on Link, LinkGroup, ExpandableLinkGroup - expandIconPosition?: 'start' | 'end' prop - variant?: 'default' | 'highlighted' prop - Collapsed state: deduplicate dividers, hide sections/groups, flatten items - Design tokens: sizeSideNavigationItemHeight, spaceSideNavigationItemGap, spaceSideNavigationItemCollapsedGap - CSS refactor: BEM naming, height-based item model, transition support
- collapsed.page.tsx: basic collapsed/expanded toggle with focus management - collapsed-toggle-placement.page.tsx: toggle in 4 positions (top/bottom/above-items/below-items) - collapsed-panel-layout.page.tsx: integration with PanelLayout for resizable panel - collapsed-permutations.page.tsx: all item types showing collapsed behavior rules
- Flatten section/section-group children with icons in collapsed mode - Apply list-variant-root--collapsed to zero padding when collapsed - Apply list-variant-root--symmetric for highlighted variant in expanded mode - Improve demo pages: scroll, toggle alignment, transition timing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related links, issue #, if available: n/a
How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.