Skip to content

fix: Remove deprecation annotation on side navigation externalIconAriaLabel link property #4392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
SpyZzey wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

fix: Remove deprecation annotation on side navigation externalIconAriaLabel link property #4392

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
31761ec
fix: Remove incorrect deprecation message on externalIconAriaLabel
SpyZzey Mar 27, 2026
99e11ae
chore: Update snapshots
SpyZzey Mar 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/__tests__/snapshot-tests/__snapshots__/documenter.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24536,7 +24536,6 @@ Links are rendered as \`<a>\` tags.
The anchor also has the attributes \`target="_blank"\` and \`rel="noopener"\`.
Additionally, the \`activeHref\` property won't be modified when a user chooses the link.
- \`externalIconAriaLabel\` (string) - Adds an aria-label to the external icon.
Note: Deprecated, use i18nStrings.externalIconAriaLabel instead.
- \`info\` (ReactNode) - Enables you to display content next to the link. Although it is technically possible to insert any content,
our UX guidelines allow only to add a Badge and/or a "New" label.

Expand Down
4 changes: 0 additions & 4 deletions src/side-navigation/interfaces.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,6 @@ export interface SideNavigationProps extends BaseComponentProps {
* The anchor also has the attributes `target="_blank"` and `rel="noopener"`.
* Additionally, the `activeHref` property won't be modified when a user chooses the link.
* - `externalIconAriaLabel` (string) - Adds an aria-label to the external icon.
* Note: Deprecated, use i18nStrings.externalIconAriaLabel instead.
* - `info` (ReactNode) - Enables you to display content next to the link. Although it is technically possible to insert any content,
* our UX guidelines allow only to add a Badge and/or a "New" label.
*
Expand Down Expand Up @@ -147,9 +146,6 @@ export namespace SideNavigationProps {
text: string;
href: string;
external?: boolean;
/**
* @deprecated Use i18nStrings.externalIconAriaLabel instead.
*/
externalIconAriaLabel?: string;
info?: React.ReactNode;
}
Expand Down
Loading