Skip to content

feat: Divider component#4364

Draft
timogasda wants to merge 5 commits intomainfrom
gasda/divider-component
Draft

feat: Divider component#4364
timogasda wants to merge 5 commits intomainfrom
gasda/divider-component

Conversation

@timogasda
Copy link
Copy Markdown
Member

Description

Related links, issue #, if available: n/a

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

- Horizontal divider using <hr> with design tokens
- decorative prop (default true): role="presentation" vs role="separator" + aria-orientation
- Style API: borderColor, borderWidth
- nativeAttributes support
- Test utils (dom + selectors), unit tests, dev pages
- Registered in index.ts, test-utils, pluralize map

API proposal: https://quip-amazon.com/lMIqAuxBLab5
Research: https://quip-amazon.com/VaJfA8cnK7lR
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.45%. Comparing base (3dcd7e0) to head (ba80193).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4364   +/-   ##
=======================================
  Coverage   97.45%   97.45%           
=======================================
  Files         902      905    +3     
  Lines       26468    26483   +15     
  Branches     9540     9544    +4     
=======================================
+ Hits        25794    25809   +15     
  Misses        631      631           
  Partials       43       43           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant