Conversation
5a2b62e to
07e7135
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4315 +/- ##
=======================================
Coverage 97.44% 97.45%
=======================================
Files 906 909 +3
Lines 26561 26632 +71
Branches 9582 9613 +31
=======================================
+ Hits 25882 25953 +71
Misses 673 673
Partials 6 6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
d96eda4 to
9168444
Compare
5c20c44 to
f28e7a1
Compare
51ff948 to
7612490
Compare
jperals
reviewed
Mar 20, 2026
jperals
reviewed
Mar 26, 2026
jperals
reviewed
Mar 26, 2026
style-dictionary/classic/shadows.ts
Outdated
| import { tokens as parentTokens } from '../visual-refresh/shadows.js'; | ||
|
|
||
| const tokens: StyleDictionary.ShadowsDictionary = { | ||
| shadowCard: { |
Member
There was a problem hiding this comment.
Until now, the cards in Classic were inheriting the shadow style from the container (see lines 39 to 41 in the removed file src/internal/components/card/styles.scss):
&:not(.refresh)::after {
box-shadow: awsui.$shadow-container;
}
So I think to keep backwards compatibility this should be {shadowContainer}.
jperals
reviewed
Mar 26, 2026
jperals
reviewed
Mar 26, 2026
418c86f to
f0478e3
Compare
jperals
previously approved these changes
Mar 27, 2026
NathanZlion
approved these changes
Mar 27, 2026
jperals
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pr exposes our card component externally.
Introduces the public ItemCard component in our public API, which exposes the previously internal Card component.
The internal Card is removed and replaced by ItemCard, including instances in the Cards component.
InternalItemCardinstead ofCard,Related links, issue #, if available: hiEUAPCbkCZS
How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.