feat: Add optional Sentry support #2386
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
murarustefaan
approved these changes
Jan 9, 2026
hermanschaaf
approved these changes
Jan 9, 2026
Member
|
@disq I'm wondering if it would not be better to have DSNs hardcoded in plugins as we used to have (trough a SDK option) rather than having them injected on-demand since the latter could cause mix-matches between plugins. This way we can opt-in Sentry, but the DSNs would be plugin-tied rather than dynamic. |
disq
changed the title
disq
commented
Jan 9, 2026
| Long: servePluginShort, | ||
| Args: cobra.NoArgs, | ||
| RunE: func(cmd *cobra.Command, _ []string) error { | ||
| doSentry, _ := strconv.ParseBool(os.Getenv("CQ_SENTRY_ENABLED")) |
Member
Author
There was a problem hiding this comment.
This is the thing to enable sentry.
hermanschaaf
approved these changes
Jan 9, 2026
| Args: cobra.NoArgs, | ||
| RunE: func(cmd *cobra.Command, _ []string) error { | ||
| doSentry, _ := strconv.ParseBool(os.Getenv("CQ_SENTRY_ENABLED")) | ||
| if doSentry && noSentry { |
Member
There was a problem hiding this comment.
For future us, but we'll probably want to remove noSentry.
Comment on lines
+231
to
+242
| ServerName: "oss", // set to "oss" on purpose to avoid sending any identifying information | ||
| // https://docs.sentry.io/platforms/go/configuration/options/#removing-default-integrations | ||
| Integrations: func(integrations []sentry.Integration) []sentry.Integration { | ||
| var filteredIntegrations []sentry.Integration | ||
| for _, integration := range integrations { | ||
| if integration.Name() == "Modules" { | ||
| continue | ||
| } | ||
| filteredIntegrations = append(filteredIntegrations, integration) | ||
| } | ||
| return filteredIntegrations | ||
| }, |
murarustefaan
approved these changes
Jan 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of https://linear.app/cloudquery/issue/ENG-2544/
Goes with cloudquery/plugin-pb-go#600Brings back sentry init and panic handling from #1724