Add CI security blog post and remove legacy pull_request_target workflow#900
Open
Add CI security blog post and remove legacy pull_request_target workflow#900
Conversation
Adds a changelog blog post about hardening PR preview workflows following a responsible disclosure, removes the last remaining pull_request_target-based workflow, and updates package-lock.json. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Instead of deleting the legacy workflow, rewrite it to demonstrate the secure pattern: use `pull_request` instead of `pull_request_target`, add a `plan` environment for approval gating, and use `github.sha` instead of the PR head ref. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Restore the Atmos Terraform Plan section in example-workflows.mdx now that the workflow has been rewritten to use pull_request + environment instead of pull_request_target. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what
pull_request_target-based workflow (atmos-terraform-plan.yaml) fromexamples/legacy/snippets/package-lock.jsonwith peer dependency annotationswhy
pull_request_targetworkflows can bypass PR approval gates when they execute code influenced by untrusted PRsreferences