-
Notifications
You must be signed in to change notification settings - Fork 219
Use golang/protobuf instead of gogo/protobuf #992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
ebroberson
wants to merge
146
commits into
develop
Choose a base branch
from
protobuf-with-plugin
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
146 commits
Select commit
Hold shift + click to select a range
48f3aed
Update to use the latest protobufs
ebroberson e4ae099
Merge branch 'main' into protobuf-with-plugin
ebroberson 53ce6cf
Merge branch 'main' into protobuf-with-plugin
ebroberson 64e38fa
Merge branch 'main' into protobuf-with-plugin
ebroberson 7a4ff16
Merge branch 'main' into protobuf-with-plugin
ebroberson bcc03c6
Merge branch 'main' into protobuf-with-plugin
ebroberson c3b1fff
Updates to match new locket protobufs
ebroberson d370dca
Updates to use new bbs and locket protobufs
ebroberson cd27101
Update struct references to match new protobufs
ebroberson 3ace9cc
Update inigo for routing-api port type changes
geofffranks 1a343c3
Fix bad fmting
geofffranks 6ef1b11
Fix bug
geofffranks a36a0c9
Updates to use new protobufs
ebroberson cca468b
Instances has to be set explicitly to 0 since it's a pointer now
ebroberson dd5bec3
Change port logic to use uint16 instead of int
ebroberson 6421a18
InternalRoutesFromRoutingInfo now takes a pointer
ebroberson d1850d7
Updates to use new protobufs
ebroberson 5475233
Remove gogoprotobuf in favor of google protobuf
ebroberson 256c3c8
Clean go.mod
ebroberson eede90e
Bump https://github.com/jqlang/jq/releases/tag/jq-1.7
tas-runtime-bot 5ca3aaf
Bump https://github.com/rprichard/winpty/releases/tag/0.4.2
tas-runtime-bot e7b89e8
Bump bbs (remove old protobuf models)
ebroberson 0d670d3
bump credhub-cli
tas-runtime-bot c684e01
Update go.mod dependencies
tas-runtime-bot be84a43
Sync package specs
tas-runtime-bot e18fde7
Bump bbs, executor, rep, garden, grootfs, guardian, idmapper (file-based
ebroberson bdf45ce
Merge branch 'develop' into protobuf-with-plugin
ebroberson a618402
Bump bbs
ebroberson e6ed406
Fix .final_builds yaml for golang
ebroberson 641f6bd
Add credhub-cli branch to .gitmodules
ebroberson a4213d0
Bump locket, executor
ebroberson 475db1f
Merge branch 'main' into protobuf-with-plugin
ebroberson b332c16
Attempt to remove SidecarRootFS changes
ebroberson 32ebbf4
Bump credhub-cli, executor, rep, grootfs
ebroberson 3778df5
Merge branch 'develop' into protobuf-with-plugin
ebroberson 7dd2113
Bump inigo (force-undo revert)
ebroberson 90ebd5c
Bump bbs (performance tests)
ebroberson bc08dfa
Bump bbs, locket (new backwards-compatible locket protobufs)
ebroberson 594f3cb
Sync locket spec
ebroberson 5ebb364
Bump bbs, locket
ebroberson f933039
Update for new locket protobufs
ebroberson 6d93ee7
Update for new locket protobufs
ebroberson e706d6b
Update for new locket protobufs
ebroberson b168545
Bump auctioneer, cfdot, rep, route-emitter, routing-api
ebroberson 8cff32b
Bump bbs, locket (regen protos)
ebroberson 80bf1e1
Bump locket
ebroberson 38e66c3
Bump bbs, locket
ebroberson 6a36f59
Merge branch 'main' into protobuf-with-plugin
ebroberson 3559f3d
Merge branch 'main' into protobuf-with-plugin
ebroberson 27a8a03
Merge branch 'main' into protobuf-with-plugin
ebroberson f2623cf
Bump actioneer, bbs, buildpackapplifecycle, cacheddownloader, cfdot, …
ebroberson dc69510
Merge develop into protobuf-with-plugin
ebroberson 52de130
Bump bbs
ebroberson 1e5cd3f
Bump bbs, locket
ebroberson d9f152a
Upgrade golang-1.23-linux (1.23.8)
tas-runtime-bot 52c3f0a
Upgrade golang-1.23-windows (1.23.8)
tas-runtime-bot c819460
bump credhub-cli garden grootfs guardian idmapper
tas-runtime-bot f68d4b4
Update go.mod dependencies
tas-runtime-bot c68408a
Sync package specs
tas-runtime-bot 8a612a1
Merge branch 'main' into protobuf-with-plugin
ebroberson 11a2677
Bump bbs, inigo, rep, garden, grootfs, guardian, idmapper
ebroberson 805e74f
Merge branch 'develop' into protobuf-with-plugin
ebroberson 4668b76
go mod tidy && go mod vendor
ebroberson 8458a79
bump credhub-cli garden grootfs guardian idmapper
tas-runtime-bot c5453d1
Update go.mod dependencies
tas-runtime-bot c877780
Bump locket (regen certs)
ebroberson c7483e2
Merge branch 'main' into protobuf-with-plugin
ebroberson 4633e53
Merge branch 'main' into protobuf-with-plugin
ebroberson 95599b8
Bump+merge submodules
ebroberson 73cd7a9
Merge branch 'develop' into protobuf-with-plugin
ebroberson 510b253
Bump bbs
ebroberson 268faa4
Upgrade golang-1.24-linux (1.24.2)
tas-runtime-bot 2bf3c12
Upgrade golang-1.24-windows (1.24.2)
tas-runtime-bot a22f16a
Upgrade golang-1.24-linux (1.24.3)
tas-runtime-bot 11e5dfc
Upgrade golang-1.24-windows (1.24.3)
tas-runtime-bot 55615da
Bump bbs, locket
ebroberson c177ac3
Bump bbs (skip perf tests)
ebroberson ea5208e
Bump bbs (task reuse fix)
ebroberson 040727f
Merge branch 'main' into protobuf-with-plugin
ebroberson 67ea2bd
Merge branch 'main' into protobuf-with-plugin
ebroberson 186bee7
Merge branch 'main' into protobuf-with-plugin
ebroberson e60bce2
submodules: merge main
ebroberson c10cefc
Merge branch 'develop' into protobuf-with-plugin
ebroberson 7f60b43
Sync package specs
ebroberson 9337ebc
Bump bbs, lock (regen protos)
ebroberson e707e8b
add archive message
ameowlia 1cc72f1
archive notice
ameowlia 7140418
archive notice
ameowlia b1c6a9c
archive notice
ameowlia 1db576e
archive notice
ameowlia 333a80d
archive notice
ameowlia 5bf65e6
archive notice
ameowlia 1489753
archive notice
ameowlia 57e5bd5
archive notice
ameowlia 3797571
Remove submodule auction for subtree migration
ebroberson 16398e2
Add 'src/code.cloudfoundry.org/auction/' from commit '1db576e7bb568d6…
ebroberson f734a4e
Remove .github and README-type files from auction
ebroberson c32737b
Remove submodule auctioneer for subtree migration
ebroberson 3664153
Add 'src/code.cloudfoundry.org/auctioneer/' from commit '040727f58bfd…
ebroberson bb26ac5
Remove .github and README-type files from auctioneer
ebroberson 25f20b3
Remove submodule cfdot for subtree migration
ebroberson 9ebb40b
Add 'src/code.cloudfoundry.org/cfdot/' from commit '3559f3d10b6ac3e27…
ebroberson 30f7ae0
Remove .github and README-type files from cfdot
ebroberson ce579e4
Remove submodule diego-ssh for subtree migration
ebroberson 394f36a
Add 'src/code.cloudfoundry.org/diego-ssh/' from commit 'c7483e25ab488…
ebroberson a336a65
Remove .github and README-type files from diego-ssh
ebroberson 462c640
Remove submodule dockerapplifecycle for subtree migration
ebroberson c39c327
Add 'src/code.cloudfoundry.org/dockerapplifecycle/' from commit 'e707…
ebroberson 61b544a
Remove .github and README-type files from dockerapplifecycle
ebroberson df82ffd
Remove submodule ecrhelper for subtree migration
ebroberson 5661463
Add 'src/code.cloudfoundry.org/ecrhelper/' from commit '5bf65e63bab5c…
ebroberson 6e23be0
Remove .github and README-type files from ecrhelper
ebroberson 4b54a41
Remove submodule fileserver for subtree migration
ebroberson 0ef9e5c
Add 'src/code.cloudfoundry.org/fileserver/' from commit '7140418ad4b8…
ebroberson 5aa40db
Remove .github and README-type files from fileserver
ebroberson 149127b
Remove submodule healthcheck for subtree migration
ebroberson 3d602e0
Add 'src/code.cloudfoundry.org/healthcheck/' from commit '333a80d1fe9…
ebroberson 1b0db42
Remove .github and README-type files from healthcheck
ebroberson 97df0d2
Remove submodule inigo for subtree migration
ebroberson a5e7980
Add 'src/code.cloudfoundry.org/inigo/' from commit '67ea2bdbf87d64658…
ebroberson c07ad1e
Remove .github and README-type files from inigo
ebroberson 30926cd
Remove submodule localdriver for subtree migration
ebroberson 54d9c07
Add 'src/code.cloudfoundry.org/localdriver/' from commit '57e5bd5b1e0…
ebroberson a922cc4
Remove .github and README-type files from localdriver
ebroberson 7dfb773
Remove submodule operationq for subtree migration
ebroberson 02ec435
Add 'src/code.cloudfoundry.org/operationq/' from commit 'b1c6a9c2437f…
ebroberson 0c21682
Remove .github and README-type files from operationq
ebroberson 58a5a4d
Remove submodule route-emitter for subtree migration
ebroberson 121fc3e
Add 'src/code.cloudfoundry.org/route-emitter/' from commit '186bee7f2…
ebroberson b7aa33e
Remove .github and README-type files from route-emitter
ebroberson 5f6c688
Remove submodule vizzini for subtree migration
ebroberson 63e0521
Add 'src/code.cloudfoundry.org/vizzini/' from commit '4633e53c7b2fd56…
ebroberson cb1d0af
Remove .github and README-type files from vizzini
ebroberson 2f2a4a5
Remove submodule volman for subtree migration
ebroberson 26f7120
Add 'src/code.cloudfoundry.org/volman/' from commit '1cc72f1031b767fe…
ebroberson 54a1409
Remove .github and README-type files from volman
ebroberson 380c9a5
Remove submodule workpool for subtree migration
ebroberson 179a303
Add 'src/code.cloudfoundry.org/workpool/' from commit '1489753f182ea8…
ebroberson 3d9acf2
Remove .github and README-type files from workpool
ebroberson 412609c
go mod tidy && go mod vendor
ebroberson 58a8fe3
Update submodules
ebroberson 84c70ce
Handle merge conflicts
ebroberson 940defb
Bump credhub-cli
ebroberson 4811eeb
go mod tidy && go mod vendor
ebroberson daf3a0e
Manual sync package spec
ebroberson 952e819
CI doesn't like that ginkgo/automaxprocs exists in vizzini spec
ebroberson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,23 +1,23 @@ | ||
| [submodule "src/code.cloudfoundry.org/bbs"] | ||
| path = src/code.cloudfoundry.org/bbs | ||
| url = https://github.com/cloudfoundry/bbs | ||
| branch = main | ||
| branch = protobuf-with-plugin | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. These should all get updated back to main before merging |
||
| [submodule "src/code.cloudfoundry.org/cacheddownloader"] | ||
| path = src/code.cloudfoundry.org/cacheddownloader | ||
| url = https://github.com/cloudfoundry/cacheddownloader | ||
| branch = main | ||
| [submodule "src/code.cloudfoundry.org/executor"] | ||
| path = src/code.cloudfoundry.org/executor | ||
| url = https://github.com/cloudfoundry/executor | ||
| branch = main | ||
| branch = protobuf-with-plugin | ||
| [submodule "src/code.cloudfoundry.org/locket"] | ||
| path = src/code.cloudfoundry.org/locket | ||
| url = https://github.com/cloudfoundry/locket | ||
| branch = main | ||
| branch = protobuf-with-plugin | ||
| [submodule "src/code.cloudfoundry.org/rep"] | ||
| path = src/code.cloudfoundry.org/rep | ||
| url = https://github.com/cloudfoundry/rep | ||
| branch = main | ||
| branch = protobuf-with-plugin | ||
| [submodule "src/code.cloudfoundry.org/buildpackapplifecycle"] | ||
| path = src/code.cloudfoundry.org/buildpackapplifecycle | ||
| url = https://github.com/cloudfoundry/buildpackapplifecycle | ||
|
|
@@ -28,11 +28,11 @@ | |
| [submodule "src/code.cloudfoundry.org/routing-info"] | ||
| path = src/code.cloudfoundry.org/routing-info | ||
| url = https://github.com/cloudfoundry-incubator/routing-info | ||
| branch = main | ||
| branch = protobuf-with-plugin | ||
| [submodule "src/code.cloudfoundry.org/routing-api"] | ||
| path = src/code.cloudfoundry.org/routing-api | ||
| url = https://github.com/cloudfoundry-incubator/routing-api | ||
| branch = main | ||
| branch = protobuf-with-plugin | ||
| [submodule "src/code.cloudfoundry.org/guardian"] | ||
| path = src/guardian | ||
| url = https://github.com/cloudfoundry/guardian | ||
|
|
@@ -46,6 +46,7 @@ | |
| [submodule "src/code.cloudfoundry.org/credhub-cli"] | ||
| path = src/code.cloudfoundry.org/credhub-cli | ||
| url = https://github.com/cloudfoundry-incubator/credhub-cli/ | ||
| branch = main | ||
| [submodule "src/garden"] | ||
| path = src/garden | ||
| url = https://github.com/cloudfoundry/garden | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes to all the .final_builds/packages concern me here. We should keep whatever's on main rather than the protobuf branch, right?