Fix Windows test deadlock by removing aggressive defer cleanup#1138
Merged
Conversation
The previous defer cleanup logic was causing test deadlocks on Windows: - defer functions were checking session.ExitCode() == -1 and calling Kill() - This interfered with natural process termination via session.Terminate() - Tests failed with "Expected process to exit. It did not." Solution: - Remove aggressive defer cleanup from individual test cases - Rely on AfterEach cleanup for port management - Let processes exit naturally without interference - Keep cross-platform signal handling (Windows: 42, Unix: 143) This allows Windows tests to pass while maintaining proper cleanup through the existing AfterEach hook and Serial execution. Made-with: Cursor
ameowlia
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous defer cleanup logic was causing test deadlocks on Windows:
Solution:
This allows Windows tests to pass while maintaining proper cleanup through the existing AfterEach hook and Serial execution.
Made-with: Cursor
Summary
Backward Compatibility
Breaking Change? Yes/No