Fix Windows unit test compatibility and port management#1137
Merged
Conversation
Addresses Windows-specific test failures in fake app/proxy unit tests: 1. **Signal Handling Fix**: - Added cross-platform signal handling for SIGTERM tests - Windows: expect exit code 42 (natural termination) - Unix: expect exit code 143 (128 + SIGTERM signal 15) 2. **Port Management Improvements**: - Added aggressive session cleanup with defer functions - Added Windows-specific delays to allow port release - Ensures all test processes are properly terminated - Prevents "Only one usage of each socket address" errors 3. **Session Lifecycle Management**: - Added proper session cleanup to all unit tests - Kill any remaining processes after test completion - Cross-platform cleanup timing adjustments These changes ensure unit tests pass on both Windows and Unix platforms while maintaining the same test behavior and coverage. Made-with: Cursor
ameowlia
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses Windows-specific test failures in fake app/proxy unit tests:
Signal Handling Fix:
Port Management Improvements:
Session Lifecycle Management:
These changes ensure unit tests pass on both Windows and Unix platforms while maintaining the same test behavior and coverage.
Made-with: Cursor
Summary
Backward Compatibility
Breaking Change? Yes/No