Fix inigo on windows for sidecar codependency tests#1136
Merged
Conversation
Replaces syscall.Kill usage with cross-platform panic approach to simulate SIGABRT behavior. On Windows, syscall.Kill is not available, so using panic provides consistent abnormal termination behavior across platforms. Changes: - Remove syscall import and usage from fake apps - Use panic() for exit code 134 (SIGABRT simulation) - Update unit tests to expect panic exit code (2) instead of platform-specific SIGABRT codes - Maintains cross-platform compatibility for Windows builds The panic approach provides equivalent abnormal termination behavior as SIGABRT while working on all supported platforms. Made-with: Cursor
Adds cross-platform support to resolve multiple Windows compatibility issues in the codependency integration tests: Cross-platform build configuration: - Detect target platform and build appropriate binaries - Use .exe suffix on Windows, no suffix on Linux - Apply static linking flags only for Linux builds - Build Windows binaries for Windows containers, Linux for Linux containers Cross-platform shell commands: - Use cmd.exe /C on Windows instead of sh -c - Handle different command syntax between platforms - Support both Windows and Unix shell environments Cross-platform paths and permissions: - Use C:\temp on Windows instead of /tmp - Handle Windows vs Unix path separators correctly - Skip Unix file permissions (chmod) on Windows - Cross-platform file path construction These changes ensure the integration tests work correctly on both Windows and Linux/macOS development environments while targeting the appropriate container platform for each OS. Made-with: Cursor
ameowlia
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes inigo on windows
Backward Compatibility
Breaking Change? no