Draft
Conversation
1 task
f0890f1 to
59ff62d
Compare
Member
Author
|
cloudfoundry/archiver#74 got merged and consumed in diego-release, dropped the commit and force-pushed. Now I only need to fix the BOSH blob. |
Member
|
@maxmoehl , @geofffranks, and I chatted in a zoom. The outcome was...
|
59ff62d to
9eb66ca
Compare
Member
Author
Depends on this being merged.
|
9eb66ca to
490538c
Compare
Member
Author
|
I've adjusted the code to use the libpcap from the bosh blob and rebased on the latest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is the implementation of RFC 0048 / #1076.
In its current state the PR cannot be merged (and will be a draft PR for now) as there are two hacks left which have to be cleaned up:
autogen.shwas causing issues down the line. Either we add the libpcap release tar-ball as a blob or fix the autogen.The PR can be built into a release and deployed. To test the feature you can SSH into an app that was deployed after the change has been deployed and then observe traffic like this:
This will print the HTTP traffic to the app process in plain-text to your terminal (while being safely escaped by tcpdump which is not the case for raw output from cf-pcap).
I'm looking for some early feedback on the changes so feel free to leave a review!
Backward Compatibility
Breaking Change? No
Disclaimer: The development of this PR was supported by Claude Code.