Route policies follow ups#5242
Draft
philippthun wants to merge 1 commit into
Draft
Conversation
philippthun
force-pushed
the
route-policies-follow-ups
branch
4 times, most recently
from
41f4eb4 to
1482488
Compare
Move notify_diego and audit-event recording out of the model and controller into RoutePolicyCreate/Update/Destroy actions, and move the cf:any exclusivity check into the model's validate. Collapse the controller's read round-trips with an eager-loaded fetch. Tidy the presenters and include decorators, and expand spec coverage: authorization matrix, deep body assertions, transaction-rollback paths, and FactoryBot factories for the new models. Correct the route-policy and domain V3 docs.
philippthun
force-pushed
the
route-policies-follow-ups
branch
from
1b84481 to
d8f09ba
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to cloud_controller_ng. To speed up the process of reviewing your pull request please provide us with:
A short explanation of the proposed change:
An explanation of the use cases your change solves
Links to any other associated PRs
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests