Fix/speedup service brokers get endpoint#5098
Open
serdarozerr wants to merge 2 commits into
Open
Conversation
When service broker space scoped, during build_relationships inside service_broker_presenter.rb it makes select query for each of them and that makes N+1 problem. With eager loading it would be adding all the spaces as association into service broker so it won't make queries anymore will just fetch from cache.
…t have space association
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During get request to service_brokers endpoint, if service broker is associated with space, it fetch also space information, that leads to N+1 query problem. With this PR we add eager loading for :space association to load all the necessary space information with 1 query.
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests