Add TooManyMigrationRuns cop to test performance#4850
Open
Conversation
johha
force-pushed
the
migration-cop
branch
4 times, most recently
from
535949c to
90cc5e2
Compare
philippthun
reviewed
Mar 6, 2026
Enforces max 4 migration runs per test file to prevent expensive repeated migrations. Detects subjects, let helpers, helper methods, and before/after blocks. Intentionally simple to avoid false positives on edge cases. Also reduce number of migration calls in `_add_state_to_stacks_spec` to please Rubbcop. Disable cop for `bigint_migration_*_shared_context` & `drop_unique_constraint_quota_definitions_name_key_spec.rb`.
- Fix empty file handling (nil AST guard) - Replace fragile string matching with AST-based detection - Consolidate AST traversals into fewer passes - Remove unused parameter and fix method naming - Add comprehensive spec covering all detection patterns
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enforces max 4 migration runs per test file to prevent expensive repeated migrations. Detects subjects, let helpers, helper methods, and before/after blocks. Intentionally simple to avoid false positives on edge cases.
Also reduce number of migration calls in
_add_state_to_stacks_specto please Rubocop.I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests