Make dynamic ASG test endpoint configurable#604
Open
peterellisjones wants to merge 1 commit intocloudfoundry:developfrom
Open
Make dynamic ASG test endpoint configurable#604peterellisjones wants to merge 1 commit intocloudfoundry:developfrom
peterellisjones wants to merge 1 commit intocloudfoundry:developfrom
Conversation
|
|
f0283ba to
c3f61ca
Compare
Member
|
Closing this PR due to inactivity. Please feel free to reopen it if you're still interested 😄 |
Author
|
@ctlong this is still a relevant and useful change -- it's just been waiting for someone to review and merge it |
Member
|
From a quick glance the changes LGTM! @peterellisjones can you please rebase this PR and I'll perform a more thorough review? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Are you submitting this PR against the develop branch?
👍
What is this change about?
Currently the Dynamic ASG test works the following way:
cloud-controller-ng.service.cf.internal:9024/v2/info9024in IP range10.0.0.0/8This test requires/assumes that:
cloud-controller-ng.service.cf.internal:9024is currently blocked by the platform-wide running ASGs10.0.0.0/8cloud-controller-ng.service.cf.internalresolves to a Cloud Controller VM IPThis PR adds an optional configuration parameter
dynamic_asg_test_configwhich can be used to change the test to work in environments where the above assumptions don't hold. By default the test will use the current logic, butdynamic_asg_test_configcan be used to override the following parameters:endpoint_host: Hostname or IP for test endpoint to allow/blockendpoint_port: Port for test endpoint to allow/blockendpoint_path: HTTP Path for test endpoint to allow/blockendpoint_allow_ip_range: IP range used for allowing and blocking access to the test endpoint. This can be a single IP address, a range like 192.0.2.0-192.0.2.50, or a CIDR block like 10.0.0.0/8.What version of cf-deployment have you run this cf-acceptance-test change against?
21.9
Please check all that apply for this PR:
Did you update the README as appropriate for this change?
How many more (or fewer) seconds of runtime will this change introduce to CATs?
0
What is the level of urgency for publishing this change?
Tag your pair, your PM, and/or team!
This work is done on behalf of Fidelity International