Add cflinuxfs5 acceptance tests#1946
Open
Milena-Encheva wants to merge 1 commit into
Open
Conversation
Milena-Encheva
force-pushed
the
validation_cflinuxfs5
branch
from
5df718c to
ce4e924
Compare
davewalter
approved these changes
May 26, 2026
jochenehret
requested changes
May 26, 2026
|
|
||
| defaults.Stacks = &[]string{"cflinuxfs4"} | ||
|
|
||
| // NOTE: To test cflinuxfs5, override the stacks property in your cats config: |
Contributor
There was a problem hiding this comment.
Notes for the test configuration should be added here:
https://github.com/cloudfoundry/cf-acceptance-tests#test-configuration
No need for comments here.
| Expect(config.GetCredHubLocation()).To(Equal("https://credhub.service.cf.internal:8844")) | ||
|
|
||
| Expect(config.GetStacks()).To(ConsistOf("cflinuxfs4")) | ||
| // NOTE: cflinuxfs5 is also supported - override stacks in config to test it |
Contributor
There was a problem hiding this comment.
No need for a comment, the tests below explain how cflinuxfs5 is handled.
jochenehret
requested changes
May 26, 2026
Contributor
jochenehret
left a comment
jochenehret
left a comment
There was a problem hiding this comment.
Looks good, only the comments can be removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Are you submitting this PR against the [develop branch]
Yes, this PR targets the develop branch.
What is this change about?
Adds support for the cflinuxfs5 stack (Ubuntu 24.04 Noble Numbat) to CATs, following the same pattern used when cflinuxfs4 (Ubuntu 22.04 Jammy) was introduced in PR #648.
Please provide contextual information.
Part of cloudfoundry/cf-deployment#1323. Required by the community pipeline cflinuxfs5-release to validate the new cflinuxfs5 stack
cflinuxfs5 is based on Ubuntu 24.04 Noble Numbat.
What version of cf-deployment have you run this cf-acceptance-test change against?
To be tested against cflinuxfs5-release community pipeline.
Please check all that apply for this PR:
Did you update the README as appropriate for this change?
If you are introducing a new acceptance test, what is your rationale for including it CATs rather than your own acceptance test suite?
CATs should validate common operator workflows.
CATs is not a regression test suite.
CATs is run by every component team to validate their releases before promotion.
How many more (or fewer) seconds of runtime will this change introduce to CATs?
N/A — no new tests introduced. Existing stack tests are extended to cover cflinuxfs5.
What is the level of urgency for publishing this change?
Tag your pair, your PM, and/or team!
@oliver-heinrich @jochenehret