monit_utils: Add support for more than 10 cc workers#276
Open
ohkyle wants to merge 1 commit intocloudfoundry:developfrom
Open
monit_utils: Add support for more than 10 cc workers#276ohkyle wants to merge 1 commit intocloudfoundry:developfrom
ohkyle wants to merge 1 commit intocloudfoundry:developfrom
Conversation
|
|
ohkyle
force-pushed
the
support-many-cloud-controller-workers
branch
2 times, most recently
from
b6c7507 to
cb0838e
Compare
- cloudfoundry#267 identified a bug where the wait_unmonitor_job function assumed there would be less than 10 cloud controller workers - this fix removes the less than 10 worker assumption and looks for the job_name in the regex Authored-by: Kyle Ong <kyleo@vmware.com>
ohkyle
force-pushed
the
support-many-cloud-controller-workers
branch
from
cb0838e to
52eb61d
Compare
MarcPaquette
reviewed
Feb 8, 2024
Member
MarcPaquette
left a comment
MarcPaquette
left a comment
There was a problem hiding this comment.
These changes look good to me.
MarcPaquette
approved these changes
Feb 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Authored-by: Kyle Ong kyleo@vmware.com
Thanks for contributing to the
capi_release. To speed up the process of reviewing your pull request please provide us with:A short explanation of the proposed change:
An explanation of the use cases your change solves
Links to any other associated PRs
I have viewed signed and have submitted the Contributor License Agreement
I have made this pull request to the
developbranchI have run CF Acceptance Tests on bosh lite