Skip to content

packaging: copy .bundle/confg into package#2781

Closed
aramprice wants to merge 1 commit into
mainfrom
copy-bundle-config
Closed

packaging: copy .bundle/confg into package#2781
aramprice wants to merge 1 commit into
mainfrom
copy-bundle-config

Conversation

@aramprice

Copy link
Copy Markdown
Member

This file is created by the bosh_bundle_local function used to install gems during packaging, but because the function is not executed while in $BOSH_INSTALL_TARGET the .bundle/ directory is not present in the package.

This file is created by the `bosh_bundle_local` function used to
install gems during packaging, but because the function is not executed
while in `$BOSH_INSTALL_TARGET` the `.bundle/` directory is not present
in the package.
@coderabbitai

coderabbitai Bot commented Jul 15, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 8085f5ea-50a3-45b7-b65d-3ecfeeb8a7d4

📥 Commits

Reviewing files that changed from the base of the PR and between 98c3bb4 and 75efc03.

📒 Files selected for processing (3)
  • packages/director/packaging
  • packages/health_monitor/packaging
  • packages/nats/packaging

Walkthrough

The director, health monitor, and NATS packaging scripts now use a single verbose copy operation to stage Gemfile, Gemfile.lock, and the .bundle directory in the BOSH install target. Previously, each script copied only Gemfile and Gemfile.lock through separate commands.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is only one sentence and omits the required template sections for context, tests, release notes, breaking changes, tags, and AI feedback. Rewrite the PR description using all required template sections, including change summary, context, tests run, release notes, breaking-change impact, tags, and AI review feedback.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title is concise and matches the packaging change, despite a minor typo in the path.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch copy-bundle-config

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates BOSH package build scripts to ensure Bundler’s local configuration directory (.bundle/) is included in the compiled package output. This aligns with the PR description: .bundle/config is generated during gem installation in the packaging step, but previously wasn’t present in $BOSH_INSTALL_TARGET, so it wouldn’t be shipped with the package.

Changes:

  • Copy .bundle/ into $BOSH_INSTALL_TARGET alongside Gemfile and Gemfile.lock for Ruby-based packages.
  • Consolidate multiple cp calls into a single cp -vr ... "${BOSH_INSTALL_TARGET}" invocation in each affected package.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
packages/nats/packaging Copy Gemfile, Gemfile.lock, and .bundle/ into the install target so the package includes Bundler config.
packages/health_monitor/packaging Same: include .bundle/ in the packaged output alongside Gemfile artifacts.
packages/director/packaging Same: include .bundle/ (which also captures local bundler config set during packaging).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread packages/director/packaging
@aramprice

Copy link
Copy Markdown
Member Author

Closing in favor of #2782

@aramprice aramprice closed this Jul 15, 2026
@github-project-automation github-project-automation Bot moved this from Pending Merge | Prioritized to Done in Foundational Infrastructure Working Group Jul 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

3 participants