packaging: copy .bundle/confg into package#2781
Conversation
This file is created by the `bosh_bundle_local` function used to install gems during packaging, but because the function is not executed while in `$BOSH_INSTALL_TARGET` the `.bundle/` directory is not present in the package.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (3)
WalkthroughThe director, health monitor, and NATS packaging scripts now use a single verbose copy operation to stage 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR updates BOSH package build scripts to ensure Bundler’s local configuration directory (.bundle/) is included in the compiled package output. This aligns with the PR description: .bundle/config is generated during gem installation in the packaging step, but previously wasn’t present in $BOSH_INSTALL_TARGET, so it wouldn’t be shipped with the package.
Changes:
- Copy
.bundle/into$BOSH_INSTALL_TARGETalongsideGemfileandGemfile.lockfor Ruby-based packages. - Consolidate multiple
cpcalls into a singlecp -vr ... "${BOSH_INSTALL_TARGET}"invocation in each affected package.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/nats/packaging | Copy Gemfile, Gemfile.lock, and .bundle/ into the install target so the package includes Bundler config. |
| packages/health_monitor/packaging | Same: include .bundle/ in the packaged output alongside Gemfile artifacts. |
| packages/director/packaging | Same: include .bundle/ (which also captures local bundler config set during packaging). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Closing in favor of #2782 |
This file is created by the
bosh_bundle_localfunction used to install gems during packaging, but because the function is not executed while in$BOSH_INSTALL_TARGETthe.bundle/directory is not present in the package.