Skip to content

Deprecate postgres-13 job: removal scheduled for next release#2778

Open
ZPascal wants to merge 1 commit into
cloudfoundry:mainfrom
ZPascal:deprecate-postgres-13-job
Open

Deprecate postgres-13 job: removal scheduled for next release#2778
ZPascal wants to merge 1 commit into
cloudfoundry:mainfrom
ZPascal:deprecate-postgres-13-job

Conversation

@ZPascal

@ZPascal ZPascal commented Jul 15, 2026

Copy link
Copy Markdown

Summary

Marks the `postgres-13` job as deprecated ahead of its removal in the next bosh release.

  • `jobs/postgres-13/spec` — adds deprecation notice to the job description
  • `jobs/postgres-13/templates/pre-start.erb` — emits a `WARNING` log line during `bosh deploy` so operators see it

Operators should migrate to cloudfoundry/postgres-release. See `docs/postgres-migration.md` (added in a companion PR) for the full migration guide.

Related PRs

This is one of three independent PRs split from the original postgres-release migration:

Test plan

  • `bosh deploy` with `postgres-13` job produces the deprecation WARNING in logs

The postgres-13 job will be removed in the next bosh release.
Operators should migrate to cloudfoundry/postgres-release.
See docs/postgres-migration.md for upgrade instructions.
@coderabbitai

coderabbitai Bot commented Jul 15, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 119d121e-265c-4b47-8a31-5f2fdeb8da9b

📥 Commits

Reviewing files that changed from the base of the PR and between c7e7e2b and 537c42e.

📒 Files selected for processing (2)
  • jobs/postgres-13/spec
  • jobs/postgres-13/templates/pre-start.erb

Walkthrough

The postgres-13 job metadata now marks the job as deprecated and directs users to the upstream postgres job and migration documentation. Its pre-start script also prints deprecation and migration warnings before continuing.

Suggested reviewers: aramprice

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly states the main change: deprecating postgres-13 and its next-release removal.
Description check ✅ Passed The description covers the summary, related PRs, and test plan, but leaves several template sections unfilled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR deprecates the postgres-13 BOSH job ahead of its scheduled removal, by surfacing the deprecation both in the job metadata and during deployment/startup so operators see a clear migration signal.

Changes:

  • Adds a deprecation warning message to the postgres-13 job pre-start script output.
  • Adds a description field to jobs/postgres-13/spec marking the job as deprecated and directing operators to migrate.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
jobs/postgres-13/templates/pre-start.erb Emits deprecation warning lines when the job runs its pre-start hook.
jobs/postgres-13/spec Marks the job as deprecated via the job spec description string.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +3 to +4
echo "WARNING: The postgres-13 job is deprecated and will be removed in the next bosh release."
echo "WARNING: Migrate to the postgres job from cloudfoundry/postgres-release. See docs/postgres-migration.md"
Comment thread jobs/postgres-13/spec
@@ -1,5 +1,6 @@
---
name: postgres-13
description: "DEPRECATED: This job will be removed in the next bosh release. Use the postgres job from cloudfoundry/postgres-release instead. See docs/postgres-migration.md for upgrade instructions."
@aramprice aramprice moved this from Pending Merge | Prioritized to Pending Review | Discussion in Foundational Infrastructure Working Group Jul 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Pending Review | Discussion

Development

Successfully merging this pull request may close these issues.

3 participants