Fix regex operator typo in health monitor spec #2666
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cf-foundation-community-automation
bot
moved this to Inbox
in Foundational Infrastructure Working Group
aramprice
approved these changes
Feb 12, 2026
github-project-automation
bot
moved this from Inbox
to Pending Merge | Prioritized
in Foundational Infrastructure Working Group
github-project-automation
bot
moved this from Pending Merge | Prioritized
to Done
in Foundational Infrastructure Working Group
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this change about?
Fixes a 9-year-old typo in the health monitor test that filters compilation job heartbeats. The test was using an invalid regex operator
!=~instead of the correct negated match operator!~.Please provide contextual information.
It appears this was now exposed by PR #2649.
The invalid operator
!=~(parsed as!=followed by~) always returnstrue, so compilation heartbeats weren't actually filtered outWhat tests have you run against this PR?
Ran the
spec/integration/health_monitor/hm_stateless_spec.rbtests.How should this change be described in bosh release notes?
Fixed health monitor integration test that was using incorrect regex operator for filtering heartbeats.
Does this PR introduce a breaking change?
No - this is a test-only fix.