Skip to content

[local-explorer-ui] Add restart from step button to local explorer UI#14154

Open
pombosilva wants to merge 2 commits into
mainfrom
osilva/workflows-add-restart-from-step-to-ui
Open

[local-explorer-ui] Add restart from step button to local explorer UI#14154
pombosilva wants to merge 2 commits into
mainfrom
osilva/workflows-add-restart-from-step-to-ui

Conversation

@pombosilva
Copy link
Copy Markdown
Contributor

@pombosilva pombosilva commented Jun 2, 2026

Fixes WOR-1265.

Add restart from step button to local explorer UI.

restart-from-step
  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: just adding a button and docs for this feature already exist

A picture of a cute animal (not mandatory, but encouraged)


Open in Devin Review

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Jun 2, 2026

🦋 Changeset detected

Latest commit: 3a47398

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cloudflare/local-explorer-ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ask-bonk
Copy link
Copy Markdown
Contributor

ask-bonk Bot commented Jun 2, 2026

UnknownError: ProviderInitError

github run

@workers-devprod workers-devprod requested review from a team and james-elicx and removed request for a team June 2, 2026 11:04
@ask-bonk
Copy link
Copy Markdown
Contributor

ask-bonk Bot commented Jun 2, 2026

@pombosilva Bonk workflow failed. Check the logs for details.

View workflow run · To retry, trigger Bonk again.

@workers-devprod
Copy link
Copy Markdown
Contributor

Codeowners approval required for this PR:

  • @cloudflare/wrangler
Show detailed file reviewers
  • .changeset/local-explorer-workflows-restart-from-step.md: [@cloudflare/wrangler]
  • packages/local-explorer-ui/src/e2e/workflows/workflow.spec.ts: [@cloudflare/wrangler]
  • packages/local-explorer-ui/src/tests/workflows/step-helpers.test.ts: [@cloudflare/wrangler]
  • packages/local-explorer-ui/src/components/workflows/StepRow.tsx: [@cloudflare/wrangler]
  • packages/local-explorer-ui/src/components/workflows/types.ts: [@cloudflare/wrangler]
  • packages/local-explorer-ui/src/routes/workflows/$workflowName/$instanceId.tsx: [@cloudflare/wrangler]

devin-ai-integration[bot]

This comment was marked as resolved.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Jun 2, 2026

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@14154

@cloudflare/deploy-helpers

npm i https://pkg.pr.new/@cloudflare/deploy-helpers@14154

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@14154

miniflare

npm i https://pkg.pr.new/miniflare@14154

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@14154

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@14154

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@14154

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@14154

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@14154

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@14154

wrangler

npm i https://pkg.pr.new/wrangler@14154

@cloudflare/wrangler-bundler

npm i https://pkg.pr.new/@cloudflare/wrangler-bundler@14154

commit: d552660

…$instanceId.tsx

Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 2, 2026

✅ All changesets look good

Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 new potential issue.

View 7 additional findings in Devin Review.

Open in Devin Review

Comment on lines +798 to +807
<p className="text-sm text-kumo-subtle">
This will rerun the instance from{" "}
This will rerun the instance from{" "}
<span className="font-medium text-kumo-default">
{getStepDisplayName(restartFromStepTarget?.name)}
</span>
</span>
. Saved state for this step and later steps will be cleared,
while earlier completed steps are kept.
</p>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 Corrupted JSX in restart-from-step dialog renders duplicate text

The dialog body at $instanceId.tsx:798-807 contains garbled JSX from what appears to be a copy-paste or merge error. The text "This will rerun the instance from" appears twice (lines 799 and 800), and there is an extra orphan </span> closing tag on line 804. Even if the structural JSX issue is resolved, the duplicate text on line 800 would cause the dialog to display "This will rerun the instance from This will rerun the instance from stepName…" — doubling the message shown to users.

Corrupted JSX block (lines 798–807)
<p className="text-sm text-kumo-subtle">
	This will rerun the instance from{" "}
This will rerun the instance from{" "}        // ← duplicate line
<span className="font-medium text-kumo-default">
	{getStepDisplayName(restartFromStepTarget?.name)}
</span>
	</span>                                       // ← orphan closing tag
	. Saved state for this step and later steps will be cleared,
	while earlier completed steps are kept.
</p>
Suggested change
<p className="text-sm text-kumo-subtle">
This will rerun the instance from{" "}
This will rerun the instance from{" "}
<span className="font-medium text-kumo-default">
{getStepDisplayName(restartFromStepTarget?.name)}
</span>
</span>
. Saved state for this step and later steps will be cleared,
while earlier completed steps are kept.
</p>
<p className="text-sm text-kumo-subtle">
This will rerun the instance from{" "}
<span className="font-medium text-kumo-default">
{getStepDisplayName(restartFromStepTarget?.name)}
</span>
. Saved state for this step and later steps will be cleared,
while earlier completed steps are kept.
</p>
Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

<span className="font-medium text-kumo-default">
{getStepDisplayName(restartFromStepTarget?.name)}
</span>
</span>
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
</span>

from: getRestartFromStepParam(restartFromStepTarget),
},
});
setRestartFromStepTarget(null);
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think you might want to put this in the finally block as well so that it sets to null if the function throws an error so that the dialog can close and it can show the error properly?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Untriaged

Development

Successfully merging this pull request may close these issues.

3 participants