[local-explorer-ui] Add restart from step button to local explorer UI#14154
[local-explorer-ui] Add restart from step button to local explorer UI#14154pombosilva wants to merge 2 commits into
Conversation
🦋 Changeset detectedLatest commit: 3a47398 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
UnknownError: ProviderInitError |
|
@pombosilva Bonk workflow failed. Check the logs for details. View workflow run · To retry, trigger Bonk again. |
|
Codeowners approval required for this PR:
Show detailed file reviewers
|
create-cloudflare
@cloudflare/deploy-helpers
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
@cloudflare/wrangler-bundler
commit: |
…$instanceId.tsx Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com>
|
✅ All changesets look good |
| <p className="text-sm text-kumo-subtle"> | ||
| This will rerun the instance from{" "} | ||
| This will rerun the instance from{" "} | ||
| <span className="font-medium text-kumo-default"> | ||
| {getStepDisplayName(restartFromStepTarget?.name)} | ||
| </span> | ||
| </span> | ||
| . Saved state for this step and later steps will be cleared, | ||
| while earlier completed steps are kept. | ||
| </p> |
There was a problem hiding this comment.
🔴 Corrupted JSX in restart-from-step dialog renders duplicate text
The dialog body at $instanceId.tsx:798-807 contains garbled JSX from what appears to be a copy-paste or merge error. The text "This will rerun the instance from" appears twice (lines 799 and 800), and there is an extra orphan </span> closing tag on line 804. Even if the structural JSX issue is resolved, the duplicate text on line 800 would cause the dialog to display "This will rerun the instance from This will rerun the instance from stepName…" — doubling the message shown to users.
Corrupted JSX block (lines 798–807)
<p className="text-sm text-kumo-subtle">
This will rerun the instance from{" "}
This will rerun the instance from{" "} // ← duplicate line
<span className="font-medium text-kumo-default">
{getStepDisplayName(restartFromStepTarget?.name)}
</span>
</span> // ← orphan closing tag
. Saved state for this step and later steps will be cleared,
while earlier completed steps are kept.
</p>| <p className="text-sm text-kumo-subtle"> | |
| This will rerun the instance from{" "} | |
| This will rerun the instance from{" "} | |
| <span className="font-medium text-kumo-default"> | |
| {getStepDisplayName(restartFromStepTarget?.name)} | |
| </span> | |
| </span> | |
| . Saved state for this step and later steps will be cleared, | |
| while earlier completed steps are kept. | |
| </p> | |
| <p className="text-sm text-kumo-subtle"> | |
| This will rerun the instance from{" "} | |
| <span className="font-medium text-kumo-default"> | |
| {getStepDisplayName(restartFromStepTarget?.name)} | |
| </span> | |
| . Saved state for this step and later steps will be cleared, | |
| while earlier completed steps are kept. | |
| </p> |
Was this helpful? React with 👍 or 👎 to provide feedback.
| <span className="font-medium text-kumo-default"> | ||
| {getStepDisplayName(restartFromStepTarget?.name)} | ||
| </span> | ||
| </span> |
| from: getRestartFromStepParam(restartFromStepTarget), | ||
| }, | ||
| }); | ||
| setRestartFromStepTarget(null); |
There was a problem hiding this comment.
i think you might want to put this in the finally block as well so that it sets to null if the function throws an error so that the dialog can close and it can show the error properly?
Fixes WOR-1265.
Add restart from step button to local explorer UI.
A picture of a cute animal (not mandatory, but encouraged)