Skip to content

Fixing bug when two containers share same image#13044

Draft
mikenomitch wants to merge 1 commit intomainfrom
nomitch/multi-container-sharing-image
Draft

Fixing bug when two containers share same image#13044
mikenomitch wants to merge 1 commit intomainfrom
nomitch/multi-container-sharing-image

Conversation

@mikenomitch
Copy link
Contributor

Fixes #[insert GH or internal issue link(s)].

Describe your change...


  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because:

A picture of a cute animal (not mandatory, but encouraged)

@changeset-bot
Copy link

changeset-bot bot commented Mar 24, 2026

⚠️ No Changeset found

Latest commit: 6c5c4ba

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ask-bonk
Copy link
Contributor

ask-bonk bot commented Mar 24, 2026

The logic is correct and clean. The old code would incorrectly remove tags like cloudflare-dev/other-class:some-build-id when cleaning up for cloudflare-dev/my-class:current-build-id, since both start with cloudflare-dev. The new code properly scopes removal to only tags sharing the same cloudflare-dev/<classname> repository prefix.

There are no tests for this function currently, and the PR doesn't add any, but the changeset bot already flagged the missing changeset. The code change itself is sound.

LGTM

github run

@pkg-pr-new
Copy link

pkg-pr-new bot commented Mar 24, 2026

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@13044

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@13044

miniflare

npm i https://pkg.pr.new/miniflare@13044

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@13044

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@13044

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@13044

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@13044

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@13044

wrangler

npm i https://pkg.pr.new/wrangler@13044

commit: 6c5c4ba

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Untriaged

Development

Successfully merging this pull request may close these issues.

2 participants