[wrangler] Only allow "worker" queue consumer type in wrangler config#13018
Conversation
|
Codeowners approval required for this PR:
Show detailed file reviewers |
🦋 Changeset detectedLatest commit: 6142443 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
wrangler
commit: |
2d7b119 to
ecec08a
Compare
sdnts
left a comment
There was a problem hiding this comment.
Can't actually approve, but I've taken a look and this looks good to me
97872c9 to
8f00f6c
Compare
petebacondarwin
left a comment
There was a problem hiding this comment.
Approved but I am trying to determine if this counts as a breaking change...
|
Looks like the type checks have a legitimate failure... |
8f00f6c to
9423e91
Compare
Ive tried to destructure it so that the trigger type and consumer type string don't intersect. I could also revert the type?: "worker" and make it type?: string as it was before. We wanted to strictly type it because we only want users to be able to put "worker" if they need to. |
|
I'll fix it up for you |
e0cf238 to
6142443
Compare
Fixes MQ-1262
Previously, non-worker consumer types (e.g.
http_pull) could be specified in thequeues.consumersconfig. If the type washttp_pull, we would attach an HTTP-Pull consumer to a queue. This is unrelated to a worker and should not be something users should do while deploying a worker. Now, wrangler will error if a consumertypeother than"worker"is specified in the config file.A picture of a cute animal (not mandatory, but encouraged)
