Skip to content

[wrangler] Only allow "worker" queue consumer type in wrangler config#13018

Merged
petebacondarwin merged 4 commits intocloudflare:mainfrom
tgarg-cf:tgarg/MQ-1262-remove-http-consumers-from-wrangler-binding-config
Mar 26, 2026
Merged

[wrangler] Only allow "worker" queue consumer type in wrangler config#13018
petebacondarwin merged 4 commits intocloudflare:mainfrom
tgarg-cf:tgarg/MQ-1262-remove-http-consumers-from-wrangler-binding-config

Conversation

@tgarg-cf
Copy link
Contributor

@tgarg-cf tgarg-cf commented Mar 23, 2026

Fixes MQ-1262

Previously, non-worker consumer types (e.g. http_pull) could be specified in the queues.consumers config. If the type was http_pull, we would attach an HTTP-Pull consumer to a queue. This is unrelated to a worker and should not be something users should do while deploying a worker. Now, wrangler will error if a consumer type other than "worker" is specified in the config file.


A picture of a cute animal (not mandatory, but encouraged)
image


Open with Devin

@tgarg-cf tgarg-cf requested a review from a team as a code owner March 23, 2026 15:17
@github-project-automation github-project-automation bot moved this to Untriaged in workers-sdk Mar 23, 2026
@workers-devprod
Copy link
Contributor

workers-devprod commented Mar 23, 2026

Codeowners approval required for this PR:

  • ✅ @cloudflare/wrangler
Show detailed file reviewers

@changeset-bot
Copy link

changeset-bot bot commented Mar 23, 2026

🦋 Changeset detected

Latest commit: 6142443

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

devin-ai-integration[bot]

This comment was marked as resolved.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Mar 23, 2026

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@13018

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@13018

miniflare

npm i https://pkg.pr.new/miniflare@13018

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@13018

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@13018

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@13018

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@13018

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@13018

wrangler

npm i https://pkg.pr.new/wrangler@13018

commit: 6142443

@tgarg-cf tgarg-cf force-pushed the tgarg/MQ-1262-remove-http-consumers-from-wrangler-binding-config branch from 2d7b119 to ecec08a Compare March 23, 2026 15:35
Copy link
Contributor

@sdnts sdnts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't actually approve, but I've taken a look and this looks good to me

@tgarg-cf tgarg-cf force-pushed the tgarg/MQ-1262-remove-http-consumers-from-wrangler-binding-config branch 2 times, most recently from 97872c9 to 8f00f6c Compare March 25, 2026 19:58
Copy link
Contributor

@petebacondarwin petebacondarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved but I am trying to determine if this counts as a breaking change...

@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Mar 25, 2026
@petebacondarwin
Copy link
Contributor

Looks like the type checks have a legitimate failure...

@tgarg-cf tgarg-cf force-pushed the tgarg/MQ-1262-remove-http-consumers-from-wrangler-binding-config branch from 8f00f6c to 9423e91 Compare March 25, 2026 20:38
@tgarg-cf
Copy link
Contributor Author

Looks like the type checks have a legitimate failure...

Ive tried to destructure it so that the trigger type and consumer type string don't intersect. I could also revert the type?: "worker" and make it type?: string as it was before. We wanted to strictly type it because we only want users to be able to put "worker" if they need to.

@petebacondarwin
Copy link
Contributor

I'll fix it up for you

@petebacondarwin petebacondarwin requested a review from a team as a code owner March 26, 2026 10:03
@workers-devprod workers-devprod requested a review from a team March 26, 2026 10:03
@petebacondarwin petebacondarwin force-pushed the tgarg/MQ-1262-remove-http-consumers-from-wrangler-binding-config branch from e0cf238 to 6142443 Compare March 26, 2026 10:09
@petebacondarwin petebacondarwin merged commit 9c5ebf5 into cloudflare:main Mar 26, 2026
53 of 54 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Mar 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants