MQ-1267 Change queues oldestMessageTimestamp to use kj::Date#6445
Open
KennethRuan wants to merge 2 commits intocloudflare:mainfrom
Open
MQ-1267 Change queues oldestMessageTimestamp to use kj::Date#6445KennethRuan wants to merge 2 commits intocloudflare:mainfrom
KennethRuan wants to merge 2 commits intocloudflare:mainfrom
Conversation
5 tasks
7c6cb80 to
d73a4e7
Compare
d73a4e7 to
1b54323
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In previous PRs, new metrics were added to the Queues API surface.
#6246
#6354
#6339
As pointed out in #6246, it would be clearer to return a JS Date for
oldestMessageTimestamp. This PR implements that change so thatoldestMessageTimestampin the three APIs modified above, all returnDate | undefinedinstead ofnumber.Changes
This PR includes changes to
queue.c++andqueue.hfeatures that are gated behind an experimental flag, as such they are non-breaking. We also make a correction to themetrics()method to useJSG_REQUIRE_NONNULL(see here).Sentinel Value
We wanted to surface
oldestMessageTimestampasDate | undefinedto the user. However, sinceDate(0)(JS Date at the UNIX epoch) andundefinedappear the same over the wire, we opt to treat the zero value as a sentinel and manually set it tokj::noneso that it appears asundefinedto the end user.An additional test was also added to ensure that the sentinel value is handled properly.
Testing