Skip to content

Remove repeated setTag#6431

Open
sohpeach wants to merge 1 commit intomainfrom
swallace/remove-repeated-setTag
Open

Remove repeated setTag#6431
sohpeach wants to merge 1 commit intomainfrom
swallace/remove-repeated-setTag

Conversation

@sohpeach
Copy link
Copy Markdown
Member

This is already set in getWithoutFallback

This is already set in getWithoutFallback
@sohpeach sohpeach requested review from a team as code owners March 26, 2026 17:16
@ask-bonk
Copy link
Copy Markdown
Contributor

ask-bonk bot commented Mar 26, 2026

The PR's claim is confirmed. At line 290, getWithoutFallback already sets readSpan.setTag("cache_hit"_kjc, result != kj::none) — which evaluates to false when there's no cache entry. The removed line at 553 (previously line 553 in the old code) was redundantly setting readSpan.setTag("cache_hit"_kjc, false) right after getWithoutFallback already returned kj::none (the else branch of KJ_IF_SOME).

This is a correct, trivial cleanup with no behavioral change.

LGTM

github run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants