Tankcorn/preview observability streaming#6411
Open
Ankcorn wants to merge 2 commits intocloudflare:mainfrom
Open
Tankcorn/preview observability streaming#6411Ankcorn wants to merge 2 commits intocloudflare:mainfrom
Ankcorn wants to merge 2 commits intocloudflare:mainfrom
Conversation
Ankcorn
force-pushed
the
tankcorn/preview-observability-streaming
branch
from
9722d3a to
c848ed4
Compare
Ankcorn
commented
Mar 25, 2026
| api::TraceItem::TailEventInfo::TailItem, api::TraceItem::FetchEventInfo, \ | ||
| api::TraceItem::FetchEventInfo::Request, api::TraceItem::FetchEventInfo::Response, \ | ||
| api::TraceItem::JsRpcEventInfo, api::TraceItem::HibernatableWebSocketEventInfo, \ | ||
| api::Preview, api::ScriptVersion, api::TailEvent, api::TraceItem, \ |
Author
There was a problem hiding this comment.
added api::Preview to support preview in edgeworker metrics
anonrig
reviewed
Mar 25, 2026
Comment on lines
+79
to
+84
|
|
||
| JSG_MEMORY_INFO(Preview) { | ||
| tracker.trackField("id", id); | ||
| tracker.trackField("slug", slug); | ||
| tracker.trackField("name", name); | ||
| } |
Member
There was a problem hiding this comment.
Suggested change
| JSG_MEMORY_INFO(Preview) { | |
| tracker.trackField("id", id); | |
| tracker.trackField("slug", slug); | |
| tracker.trackField("name", name); | |
| } |
Not needed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds preview metadata to the streaming tail worker onset event.
It follows the same pattern already used for
scriptVersion: the metadata is attached toOnset::WorkerInfo, serialized through the onset RPCpayload, and exposed in the JS event delivered to streaming tail workers.
What changed
Streaming tail onset events now include: