Impose limits on facet name length and nesting depth.#6325
Open
Impose limits on facet name length and nesting depth.#6325
Conversation
Name length limit: 256 chars Nesting depth limit: 4 (including root) We could increase these limits if we needed to but it's hard to imagine anyone needing more than this, in fact I have yet to see a use case for multiple levels of child facets at all.
Contributor
|
The facets feature is experimental (the test uses After thorough review, I find no actionable issues:
LGTM |
jasnell
reviewed
Mar 15, 2026
|
|
||
| // Maximum depth of the facet tree, including the root Durable Object. Root is at depth 0, so | ||
| // the deepest allowed facet is at depth MAX_FACET_TREE_DEPTH - 1. | ||
| static constexpr uint MAX_FACET_TREE_DEPTH = 4; |
Collaborator
There was a problem hiding this comment.
Minor nit: if these are only used directly within actor-state.c++, they likely don't need to be constants on the class and could be moved into an anonymous namespace in actor-state.c++
jasnell
approved these changes
Mar 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Name length limit: 256 chars
Nesting depth limit: 4 (including root)
We could increase these limits if we needed to but it's hard to imagine anyone needing more than this, in fact I have yet to see a use case for multiple levels of child facets at all.