Add callRpcMethod to python entrypoint helper#6317
Conversation
Co-authored-by: ryanking13 <ryanking13@users.noreply.github.com>
|
Only one file changed, no tests added. Let me analyze the change: Functional analysis:
Potential issues to consider:
This change is clean, minimal, well-commented, purely additive, and the implementation is correct for its stated purpose. There are no actionable issues. LGTM |
dom96
left a comment
There was a problem hiding this comment.
Hmm, the SDK dependency on python-entrypoint-helper is concerning. I wonder if we have a path towards getting rid of it. At the very least we need to make sure we add protections so that we don't accidentally break it.
| { | ||
| "dependencies": { | ||
| "@opencode-ai/plugin": "1.2.24" | ||
| "@opencode-ai/plugin": "1.2.25" |
There was a problem hiding this comment.
Yes, bonk is keep pushing changes to PRs. Will revert before merge.
We already have a SDK dependency on python-entrypoint-helper a lot and I am not sure if we can do this without defining a helper method in JS.
Yes, considering our backward compatibility policy, it would be impossible to make any breaking changes to python-entrypoint-helper at all from now on. This is applied not just to this method but to all the code in python-entrypoint-helper that we are all aware of. What kind of protection do you think we need? |
Splitted off from #6296.
Other parts of #6296 will go to workers-py.