SECENG-13376: Add getMulti() type to SecretsStoreSecret interface#6285
Draft
ang-cloudflare wants to merge 2 commits intocloudflare:mainfrom
Draft
SECENG-13376: Add getMulti() type to SecretsStoreSecret interface#6285ang-cloudflare wants to merge 2 commits intocloudflare:mainfrom
ang-cloudflare wants to merge 2 commits intocloudflare:mainfrom
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
Author
|
recheck |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
getMulti()method to theSecretsStoreSecrettype definition, allowing workers to fetch multiple secrets from the same store in a single request.Motivation
Workers that need multiple secrets currently call
get()sequentially for each one. Each call traverses the full JSRPC → service binding → edge service → QuickSilver path, with P99 latency of 200–500ms per call. For workers fetching 2–3 secrets, this compounds to 1–3s+ at the tail.The secrets store edge service already supports a batch endpoint (
store_secrets_multi), and the proxy worker now exposes it asgetMulti()via SECENG-13376. This PR adds the corresponding TypeScript type so users get autocomplete and type checking without@ts-expect-error.Usage