fix: replace CLAUDE.md symlink with real file#528
Open
NathanDrake2406 wants to merge 3 commits intocloudflare:mainfrom
Open
fix: replace CLAUDE.md symlink with real file#528NathanDrake2406 wants to merge 3 commits intocloudflare:mainfrom
NathanDrake2406 wants to merge 3 commits intocloudflare:mainfrom
Conversation
commit: |
Collaborator
|
Claude should be following symlinks. If it's not, that's a bug in Claude that they need to fix - I'd prefer not to duplicate the file in the repo... |
Contributor
Author
Hmm I just took a look at the agents.md, it's pretty bloated and kind of stale. I'll amend this PR and make an update to the file |
06e4a17 to
66112ae
Compare
- Rewrote agents.md from 393 to 130 lines using claude-md-improver skill - Replaced CLAUDE.md real file with symlink back to agents.md - Updated architecture section for unified ALS (cloudflare#450) - Added three context abstractions gotcha - Added test file mapping table - Added serverExternalPackages documentation - Removed: research tools, CI details, example walkthrough, porting strategy, smoke test docs, git workflow (duplicated global rules)
e90568d to
a772011
Compare
The symlink target was `agents.md` (lowercase) but the actual file is `AGENTS.md`. This worked on macOS (case-insensitive FS) but broke symlink resolution in tools and would fail on case-sensitive systems.
a772011 to
c2af1b6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just found out that my Claude Code hasn't been loading instructions at all cuz Claude Code doesn't load symlinks lol. Maybe that's why the code was so buggy.
While at it, rewrote
agents.mdusing theclaude-md-improverskill — it was bloated and outdated.What changed
1. CLAUDE.md symlink fix
CLAUDE.mdwas a symlink →AGENTS.md. Claude Code doesn't follow symlinks, so project-level instructions were never loaded. Re-created as a proper symlink toagents.md(lowercase, the real file).2. agents.md rewrite (393 → 135 lines)
Used the claude-md-improver skill to audit, score, and iteratively improve the file across 6 iterations.
Quality scores across iterations
Final score breakdown
gh search code, copy-paste PR flowWhat was removed (and why)
What was added/updated
RequestContextfrom 3 files and get confusedentries/annotated as code generatorsserverExternalPackages+ library compat into one sectiongh search codecommand in Code Styledev-server.tsdescriptioncloudflare/worker-entry.tsreferenceSkill used
claude-md-improver(fromclaude-plugins-official/claude-md-management) — ran 6 iterations: