Draft
Conversation
- Bump vite from ^7.3.1 to ^8.0.0 across all packages, fixtures, and examples - Bump vitest from ^3.2.1 to ^4.1.0 - Rename build.rollupOptions → build.rolldownOptions in index.ts and cli.ts (Vite 8 breaking change) - Update onwarn fallback to check both rolldownOptions and rollupOptions for backwards compat with user configs - Remove Vite 7 esbuild/tsconfigPaths compatibility branches (now always use oxc + native tsconfigPaths) - Remove dead getViteMajorVersion() function and tsconfigPaths import - Remove pnpm.overrides.rollup (Vite 8 ships rolldown, not rollup)
commit: |
|
Contributor
|
Do we need to upgrade vite-plugin-react to 6.0? It doesn't support Vite 7. Maybe we should add it as a peer dependency? Let the user choose the version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
vitefrom^7.xto^8.0.0across all 23 workspace packages (root,packages/vinext, all fixtures, all examples, benchmarks)vitestfrom^3.2.1to^4.1.0pnpm.overrides.rollup(Vite 8 ships rolldown internally)Breaking-change migrations applied
Vite 8
rollupOptions→rolldownOptions: Renamed inpackages/vinext/src/index.ts(5 occurrences across global config + rsc/ssr/client environments) andpackages/vinext/src/cli.ts(2 occurrences). Theonwarnfallback checks both names to stay compatible with user-supplied configs.esbuild→oxc: Removed theviteMajorVersion >= 8branch; always usesoxcnow.resolve.tsconfigPaths: Removed the deadvite-tsconfig-pathsplugin branch; uses Vite's nativeresolve.tsconfigPathsunconditionally.getViteMajorVersion()helper andvite-tsconfig-pathsimport.Vitest 4
vitest.config.tshad no deprecated options.Peer dependency warnings
@cloudflare/vite-plugin,@vitejs/plugin-rsc,@vitejs/plugin-react,vitefu, and@tailwindcss/vitestill declare Vite 6/7 in their peer ranges. These are pre-existing and expected; the packages work correctly with Vite 8.