add support for multiple v4 names in GetResourceRename#231
Draft
add support for multiple v4 names in GetResourceRename#231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for resources with multiple v4 names to get supported by
GetResourceRename()and tests to verifyContext
GetResourceRename()is used during global post-processing to update the name of any resource that is being referenced within the block of another resource. It would have failed for the "secondary" name for any resource that had multiple v4 names, and one did not correspond to a v5 name.Rename Types
cloudflare_argo > cloudflare_argocloudflare_access_policy > cloudflare_zero_trust_access_policycloudflare_tunnel_config > cloudflare_zero_trust_tunnel_cloudflared_configcloudflare_zero_trust_tunnel_cloudflared_config > cloudflare_zero_trust_tunnel_cloudflared_configcloudflare_tunnel_virtual_network > cloudflare_zero_trust_tunnel_cloudflared_virtual_networkcloudflare_zero_trust_tunnel_virtual_network > cloudflare_zero_trust_tunnel_cloudflared_virtual_networkauthenticated_origin_pulls > authenticated_origin_pullsauthenticated_origin_pulls > authenticated_origin_pulls_settingscloudflare_dlp_profile,cloudflare_zero_trust_dlp_profile] →cloudflare_zero_trust_dlp_custom_profilecloudflare_dlp_profile,cloudflare_zero_trust_dlp_profile] →cloudflare_zero_trust_dlp_predefined_profileAdditional Changes:
GetResourceRename()checks from unit tests, there is no logic in itGetResourceRename()for queue and zero_trust_gateway_certificate