fix: send the authorization token in a header, not the URL - #139
Open
andre-j3sus wants to merge 1 commit into
Open
fix: send the authorization token in a header, not the URL#139andre-j3sus wants to merge 1 commit into
andre-j3sus wants to merge 1 commit into
Conversation
Request URLs are routinely persisted in server-side logs, traces and error reports, so a bearer credential must not travel in one. The token now rides an `Authorization: Bearer` header on the measurement, TURN credential and logging requests. Resolved per target URL rather than once per engine, so the existing "never over plain HTTP" guard still holds for configs that mix schemes. The public config is unchanged: consumers still set `authorizationToken`. The URL-redaction helpers are gone, since no URL carries the token anymore.
|
@andre-j3sus Bonk workflow failed. Check the logs for details. View workflow run · To retry, trigger Bonk again. |
Collaborator
Author
|
/bonk |
Collaborator
Author
|
/bonk |
Collaborator
Author
|
/bonk |
andre-j3sus
marked this pull request as ready for review
August 18, 2026 17:33
Collaborator
Author
|
/bonk |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The optional
authorizationTokenwas appended to request URLs as ajwtqueryparameter. Request URLs are routinely persisted well outside the request itself
— server-side request logs, tracing span tags, error-reporting breadcrumbs — so
a bearer credential travelling in one leaks into every system that records a
URL.
This moves the token to an
Authorization: Bearerheader on the requests thatneed it: the download/upload measurement requests, the TURN credential fetch,
and the two logging endpoints.