rpc: add flow-control to when_resolved() and StreamingRequest::send()#44
Open
bodier123 wants to merge 1 commit intocloudflare:mainfrom
Open
rpc: add flow-control to when_resolved() and StreamingRequest::send()#44bodier123 wants to merge 1 commit intocloudflare:mainfrom
bodier123 wants to merge 1 commit intocloudflare:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Client::when_resolvedpreviously returnedtodo!()andStreamingRequest::sendcould spam a remote vat before the client settled.
Changes
when_resolved.StreamingRequest::sendnow awaitswhen_resolvedfor basic flow control.All unit tests pass (
cargo test --workspace) andcargo clippy --no-deps -D warningsis clean forrecapn-rpc.