Open
Conversation
CAPNP_TOOL_PATH overrides capnp tool location at build time
mikea
force-pushed
the
maizatskyi/2024-12-11-regen
branch
from
1d89b35 to
97ec679
Compare
mikea
force-pushed
the
maizatskyi/2024-12-11-regen
branch
from
6d473fe to
11d1d77
Compare
| let output = Command::new(&command) | ||
| .arg("--version") | ||
| .output() | ||
| .expect("capnp tool can't be executed, change PATH or CAPNP_TOOL_PATH"); |
Collaborator
There was a problem hiding this comment.
So what happens if I decide to make some sort of tool or plugin separate from cargo's build.rs to generate code? This library would require that it can see the capnp tool before we actually decided we need it.
Contributor
Author
There was a problem hiding this comment.
So what's the big deal? You will probably have capnc available anyway. I think it is just a minor incovenience comparing to having robust error messaging. I can throw it away if you wish, but I think it will be a much better user experience if we have it, since I assume most people will depend on recapnc through the dev dependency.
Contributor
Author
There was a problem hiding this comment.
I can also do it only if CAPNP_TOOL_PATH is set?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes all generated files from the check-in.
Also makes "capnp" dependency explicitly checked.